Skip to content

Tab container itemSelect event should pass selected tab index in the event #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunnyyadav100 opened this issue Feb 9, 2020 · 0 comments · Fixed by #1202
Closed

Tab container itemSelect event should pass selected tab index in the event #1196

sunnyyadav100 opened this issue Feb 9, 2020 · 0 comments · Fixed by #1202
Labels
feature request

Comments

@sunnyyadav100
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

As a developer, I need to know the selected tab index for further business requirements. Presently itemSelect event doesn't pass the information about selected tab index. Developer need to calculate selected index again. This can be avoided if TabContainer can emit selectedTabIndex which is already being calculated.

ui5-webcomponents/packages/main/src/TabContainer.js

Line 325 in 63ca721

item: currentSelectedTab,

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@ilhan007 ilhan007 mentioned this issue Feb 10, 2020
Merged
ilhan007 added a commit that referenced this issue Feb 11, 2020
@ilhan007
refactor(ui5-tabcontainer): provide tabIndex in tabSelect even
d8d4fdb 
The tab index is provided as event details and don't have to be calculated by users, that otherwise have to consider the tab separators, which can be a little cumbersome.

FIXES: #1196

BREAKING CHANGE: `itemSelect` is renamed to `tabSelect` and the `item` event param is renamed to `tab`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ui5-tabcontainer): provide tabIndex in tabSelect event SAP/ui5-webcomponents
2 participants
@sunnyyadav100 @ilhan007