Skip to content

ui5-tabcontainer: add custom tab support #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-zhang opened this issue Apr 9, 2020 · 3 comments
Closed

ui5-tabcontainer: add custom tab support #1453

alex-zhang opened this issue Apr 9, 2020 · 3 comments
Labels

Comments

@alex-zhang
Copy link

alex-zhang commented Apr 9, 2020

hi,

we need to add a custom tab(not the ui5-wc standard) for business requirement.

so, is there any possibility to open the slot for business customization?


image

@vladitasev
Copy link
Contributor

Hi Alex,

Currently it's not possible, due to the fact that the tab strip is built based on the metadata of the tabs (text/additional text, etc...) automatically, and the tabs themselves are only slotted underneath the strip.

There are several reasons:

  • The tabs have different presentation, based on the TabContainer's properties (TabLayout)
  • There is an overflow menu to the right when the space is too little, and in this menu the tab has a yet different representation.

Is this a hard requirement for you?

@alex-zhang
Copy link
Author

alex-zhang commented Apr 10, 2020

hi @vladitasev

thanks for your reply.

yes, we should flow the Open Closed Principle here in In my opinion. The TabContainer's data should be extendible and The Tab View should be polymorphism. We define the BaseData Structure which can support current logic,and can also can extend the Base Data Structure in TabContainer that can support the customization right?

yes, it's hard for us, or we need rewrite the all TabContainer's logics.

@vladitasev
Copy link
Contributor

Please track the progress on this here:
#1490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants