Skip to content

ui5-tab-container: iterate on design, functionality, API #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladitasev opened this issue Apr 16, 2020 · 6 comments
Closed

ui5-tab-container: iterate on design, functionality, API #1490

vladitasev opened this issue Apr 16, 2020 · 6 comments

Comments

@vladitasev
Copy link
Contributor

  • Implement the latest fiori design spec for TabContainer (if/when the spec is finished, as it is very recent).
  • Discuss whether we need 2 components actually: ui5-tab-strip, ui5-tab-container. Assess current OpenUI5 controls and how they differ.
  • How can we allow more customization by having the Fiori design by default?

@ilhan007 @MapTo0 @fifoosid

@vladitasev
Copy link
Contributor Author

Official design spec:
https://experience.sap.com/fiori-design-web/icontabbar/

@vladitasev
Copy link
Contributor Author

vladitasev commented Apr 21, 2020

SAP Design statement regarding the positioning of text below the icons:

Please note that starting with SAPUI5 version 1.40, you should only use the horizontal type of label (icon and label side by side).

It seems having the label below the icon is a legacy option, and it's not even in the current design.

This is the latest design:

https://experience.sap.com/fiori-design-web/wp-content/uploads/sites/5/2020/01/Style-Tab-Density_1-74.png

In OpenUI5, it is possible though. See:
https://ui5.sap.com/#/entity/sap.m.IconTabBar/sample/sap.m.sample.IconTabBar

In UI5 Web Components, this option was never implemented, as it was deprecated by the time we created the web components package.

@vladitasev
Copy link
Contributor Author

Available OpenUI5 controls:

  1. TabContainer
    https://ui5.sap.com/#/entity/sap.m.TabContainer

This is a control, featuring tabs with a lebel and close button. Very similar to browser tabs. More niche usage. Does not have an equivalent in UI5 Web Components (despite the name!).

  1. IconTabBar
    https://ui5.sap.com/#/entity/sap.m.IconTabBar

This is a control, featuring more universal tabs that can be used to filter, show different parts of an object, or a flow. This is the equivalent to UI5 Web Components ui5-tab-container (despite the name).

@vladitasev
Copy link
Contributor Author

Current PoCs:

@vladitasev
Copy link
Contributor Author

#1507 was merged

@vladitasev
Copy link
Contributor Author

Sample repo, showing how you can take advantage of the feature and create your own tabs:
https://github.com/vladitasev/custom-tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant