Skip to content

ui5-datepicker: error valueState would be displayed if date picker with maxDate and minDate defined has an empty value #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhangliangyi opened this issue Jun 8, 2020 · 0 comments · Fixed by #1742
Assignees
Labels
bug This issue is a bug in the code

Comments

@zhangliangyi
Copy link

Hi Colleagues,

I am from Experience Web team in SAP Successfactors.

The issue is that the datepicker with minDate and maxDate would set the valueState to Error once the date value is changed to empty value.

Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/DatePicker/
  2. Select a date in the date picker component in section DatePicker with Minimum and Maximum Date - 1/1/2020 - 4/5/2020 format-pattern="dd/MM/yyyy"
  3. Remove the value in the picker

Expected behavior
The date picker should not have the error valueState unless it is required.

Screenshots
image

Context

  • UI5 Web Components version: rc7
  • OS/Platform: MacOS
  • Browser (if relevant): Chrome
  • Other information: N/A
@zhangliangyi zhangliangyi changed the title ui5-datepicker: error valueState would be displayed if empty value with maxDate and minDate properties defined ui5-datepicker: error valueState would be displayed if date picker with maxDate and minDate properties defined has an empty value Jun 8, 2020
@zhangliangyi zhangliangyi changed the title ui5-datepicker: error valueState would be displayed if date picker with maxDate and minDate properties defined has an empty value ui5-datepicker: error valueState would be displayed if date picker with maxDate and minDate defined has an empty value Jun 8, 2020
@ilhan007 ilhan007 self-assigned this Jun 8, 2020
@ilhan007 ilhan007 added the bug This issue is a bug in the code label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants