Skip to content

Item Undefined in suggestion Popover #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allen138 opened this issue Jul 20, 2020 · 0 comments · Fixed by #1969
Closed

Item Undefined in suggestion Popover #1967

allen138 opened this issue Jul 20, 2020 · 0 comments · Fixed by #1969
Assignees
Labels

Comments

@allen138
Copy link

allen138 commented Jul 20, 2020

Describe the bug
When using ui5-li-custom to build a custom list item to insert into the suggestion popover via the hbs partial added here: #1928, and when you select the item from the suggestion popover, "item" is undefined. Upon further investigation, onItemSelected will call this._getItems() which only does querySelectorAll("ui5-li, ui5-li-groupheader"). This may also be a side effect as well, but I am unable to arrow into the suggestion popover as it seems this functionality relies on this._getItems().

To reproduce
Steps to reproduce the behavior:

  1. Clone "@xweb/common-webcomponents"
  2. Pull branch "feature/personInput"
  3. Install, start and open "http://localhost:8081/test-resources/pages/PersonInput.html"
  4. Open "CustomInput.hbs" and switch between ui5-li-custom and ui5-li to observe the different behavior
  5. In the "Default Person Search" input, type "aa".
  6. Notice you cannot arrow into the suggestedItems
  7. Click one of the items and notice the error in the js console.

Expected behavior
With the newly hbs partial added, functionality should be the same for ui5-li-custom as for ui5-li

Screenshots
item undefined ui5-li

Context

  • UI5 Web Components version: 0.21.8
  • OS/Platform: Windows 10
  • Browser (if relevant): All
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants