Skip to content

refactor(ui5-input): Add template hook for the suggestions #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jul 8, 2020

Add template hook for the suggestions list, so the third party components can entirely replace our list with another and to fully control the appearance of the suggestion items.

// CustomInputPopoverTemplate.hbs
{{>include "InputPopoverTemplate"}}

{{#*inline "suggestionsList"}}
	<ui5-my-list>
	</ui5-my-list>
{{/inline}}

Related to: #1919

@ilhan007 ilhan007 requested a review from vladitasev July 8, 2020 11:24
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed a leftover if from the sample code in the commit description.

@ilhan007 ilhan007 merged commit 78035f8 into master Jul 8, 2020
@ilhan007 ilhan007 deleted the ref-input-popup-tempalte branch July 8, 2020 12:48
@ilhan007 ilhan007 added the SAP SF label Jul 8, 2020
ilhan007 added a commit that referenced this pull request Jul 8, 2020
Add template hook for the suggestions list, so the third party components can entirely replace our list with another and to fully control the appearance of the suggestion items.

// CustomInputPopoverTemplate.hbs
{{>include "InputPopoverTemplate"}}

{{#*inline "suggestionsList"}}
	<ui5-my-list>
	</ui5-my-list>
{{/inline}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants