Skip to content

ComboBox doesn't update immediately after set value via useState #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lenient opened this issue Sep 22, 2020 · 8 comments · Fixed by #2253 or #3253
Closed

ComboBox doesn't update immediately after set value via useState #2233

lenient opened this issue Sep 22, 2020 · 8 comments · Fixed by #2253 or #3253
Assignees
Labels

Comments

@lenient
Copy link

lenient commented Sep 22, 2020

Describe the bug
The value of ComboBox doesn't update immediately after set value via useState.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/story/ui5-web-components-combobox--generated-default-story
  2. Click the down arrow to select one item from the dropdown list.
  3. Typing some text like 'test' in the value property on the right panel, you will see the ComboBox still shows the previous value text.
  4. Just click on the ComboBox, you will see the text updated.

Expected behavior
The text value should be updated immediately once changing it.

Context

  • UI5 Web Components version: v0.10.5

Affected components (if known)
ComboBox

@fifoosid
Copy link
Contributor

@MarcusNotheis I suppose that this is an issue related with the sample. Can you take a look?

@MarcusNotheis
Copy link
Collaborator

Hey @fifoosid,

looks like ComboBox is not reacting to the value update immediately. I've created this codesandbox with "plain" UI5 Web Components and I can observe the same behavior.

Web Components Version: 1.0.0-rc.8

@ilhan007
Copy link
Member

ilhan007 commented Oct 8, 2020

Hello @lenient
at first we resolved the issue the the referenced PR, but after further testing we found
side effects on the component behaviour, see the the issue: #2321

So we will revert the change and try to fix it in another way.
Sorry for the inconvenience.

BR,
ilhan

@ilhan007 ilhan007 added TOPIC RL Medium Prio bug This issue is a bug in the code labels Dec 8, 2020
@ilhan007
Copy link
Member

ilhan007 commented Dec 8, 2020

FYI @SAP/ui5-webcomponents-topic-rl

Describe the bug
The value of ComboBox doesn't update immediately after set value via useState.

Steps

  1. Go to codesandbox

  2. Click the down arrow to select one item from the dropdown list.

  3. Typing some text like 'test' in the value property on the right panel, you will see the ComboBox still shows the previous value text.

  4. Just click on the ComboBox, you will see the text updated.

Expected behavior
The text value should be updated immediately once changing it.

Note: we tried to resolve the issue in the past with the referenced PR, but after further testing we found side effects on the component behaviour, described by this issue #2321 and that's why we reverted the change.

@jaquelinebonoto
Copy link

Hi! Do we have any progress on this fix?? We are using this component and facing this situation too.
Best Regards

ndeshev added a commit to ndeshev/ui5-webcomponents that referenced this issue Jan 18, 2021
The Input's text value is now updated immediately once changing it
programmatically (via JavaScript, not by user interaction).

Fixes: SAP#2233
@ndeshev ndeshev removed their assignment Jan 27, 2021
@Martotko Martotko assigned Martotko and unassigned Martotko Jan 28, 2021
@Martotko Martotko removed their assignment Feb 5, 2021
@Martotko
Copy link
Contributor

Martotko commented Feb 5, 2021

It seems it will be handled with a backlog item.

@MarcusNotheis
Copy link
Collaborator

Hey colleagues,
any news on this issue? We are facing the same issue now in multiple apps and have to replace all ComboBox with Select components.

@MapTo0
Copy link
Member

MapTo0 commented Mar 10, 2021

I am taking over that one. We included it in the current backlog and I will update you for any progress made in a few days.

@MapTo0 MapTo0 self-assigned this Mar 10, 2021
MapTo0 added a commit that referenced this issue May 14, 2021
BREAKING CHANGE: filter value property is removed.
FIXES: #2233
MapTo0 added a commit that referenced this issue Jun 21, 2021
BREAKING CHANGE: filter value property is removed.
FIXES: #2233
MapTo0 added a commit that referenced this issue Jun 28, 2021
BREAKING CHANGE: filter value property is removed.
FIXES: #2233
ilhan007 pushed a commit that referenced this issue Jul 2, 2021
BREAKING CHANGE: filter value property is removed.
FIXES: #2233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment