Skip to content

ui5-busyindicator accessibility issues #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ee92 opened this issue Oct 21, 2020 · 2 comments · Fixed by #2938
Closed

ui5-busyindicator accessibility issues #2381

ee92 opened this issue Oct 21, 2020 · 2 comments · Fixed by #2938

Comments

@ee92
Copy link

ee92 commented Oct 21, 2020

Describe the bug
The ui5-busyindicator is not being read by screenreaders and has no tooltip.

To reproduce
Steps to reproduce the behavior:

  1. Using any screenreader (NVDA, JAWS, VoiceOver)
  2. go to https://sap.github.io/ui5-webcomponents/playground/components/BusyIndicator/
  3. click the 'Fetch List Data' button
  4. notice the busy indicator is shown, but nothing read out by the screenreader
  5. hover the mouse over any of the 3 busy indicators (Small, Medium, Large) at the top of the page
  6. notice there is no tooltip

Expected behavior

  1. When the busy indicator is shown, the screenreader should read out "Please wait"
  2. When hovered, the 3 dots should have a tooltip reading "Please wait"

Affected components
ui5-busyindicator

Organization:
SuccessFactors

Priority:
Medium

Thank you

@ilhan007
Copy link
Member

ilhan007 commented Dec 9, 2020

Hello @SAP/ui5-webcomponents-topic-rd

The BusyIndicator lacks of accessibility. There is a PR that aims to address the issues #2403.
It is up to you if you want to create your own PR/change from scratch or review the existing one #2403. You can find what speech is missing in the description.

BR,
ilhan

@ilhan007 ilhan007 added the approved This issue is approved label Jan 11, 2021
@ilhan007 ilhan007 added this to the 1.0.0-rc.13 milestone Feb 4, 2021
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.13, 1.0.0-rc.14 Mar 11, 2021
@dimovpetar dimovpetar self-assigned this Mar 18, 2021
ilhan007 pushed a commit that referenced this issue Apr 1, 2021
Tooltip, Focus is provided, so screen readers can read the component properly

Fixes #2381
ilhan007 pushed a commit that referenced this issue Apr 1, 2021
Tooltip, Focus is provided, so screen readers can read the component properly

Fixes #2381
ilhan007 pushed a commit that referenced this issue Apr 1, 2021
Tooltip, Focus is provided, so screen readers can read the component properly

Fixes #2381
@ilhan007
Copy link
Member

ilhan007 commented Apr 1, 2021

Hello @ee92 the BusyIndicator's a11y support has been improved baed on your findings in 0.29.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 1.0.0-rc.14 (released 01 Apr, 2021)
6 participants