Skip to content

Accessibility issue in ui5-daterange-picker #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pankajpandey01 opened this issue Jan 29, 2021 · 0 comments · Fixed by #2762
Closed

Accessibility issue in ui5-daterange-picker #2755

pankajpandey01 opened this issue Jan 29, 2021 · 0 comments · Fixed by #2762
Assignees
@ilhan007
Labels
enhancement New feature or request Planned TOPIC B TOPIC RL
Milestone
1.0.0-rc.12

Comments

@pankajpandey01
Copy link

Describe the bug
Text spacing is not supported in ui5-daterange-picker placeholder

To reproduce
Steps to reproduce the behavior:

  1. Go to 'https://sap.github.io/ui5-webcomponents/playground/components/DateRangePicker/'
  2. Apply Text spacing settings through "Stylus" browser extension
    https://wiki.wdf.sap.corp/wiki/display/Acc/ACC-283+Details#ACC283Details-TestMethods

Expected behavior
Placeholder should support text spacing.

Screenshots
Screen Shot 2021-01-29 at 11 53 41 AM

Context

  • UI5 Web Components version: v1.0.0-rc.8
  • OS/Platform: Mac (Not tested in other platform)

Affected components
ui5-daterange-picker

Organization:
SuccessFactors
@ilhan007 ilhan007 self-assigned this Feb 1, 2021
@ilhan007 ilhan007 added enhancement New feature or request TOPIC B TOPIC RL labels Feb 1, 2021
@ilhan007 ilhan007 mentioned this issue Feb 1, 2021
Merged
@ilhan007 ilhan007 added this to the 1.0.0-rc.13 milestone Feb 1, 2021
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.13, 1.0.0-rc.12 Feb 1, 2021
ilhan007 added a commit that referenced this issue Feb 3, 2021
@ilhan007
refactor(ui5-input, ui5-textarea, ui5-date-*): allow letter spacing (#…
c70fea9 
…2762)

Allow letter spacing in the Input, TextArea, DatePicker, DateTimePicker, DateRangePicker components with common letter spacing tool that is based on three CSS properties - line-height, letter-spacing and word-spacing by setting their default values to the host and inherit them in the native input element.

FIXES: #2755
FIXES: #2641
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
@ilhan007 @NHristov-sap
refactor(ui5-input, ui5-textarea, ui5-date-*): allow letter spacing (S…
640ed85 
…AP#2762)

Allow letter spacing in the Input, TextArea, DatePicker, DateTimePicker, DateRangePicker components with common letter spacing tool that is based on three CSS properties - line-height, letter-spacing and word-spacing by setting their default values to the host and inherit them in the native input element.

FIXES: SAP#2755
FIXES: SAP#2641
ilhan007 added a commit that referenced this issue Apr 6, 2021
@ilhan007
refactor(ui5-input, ui5-textarea, ui5-date-*): allow letter spacing (#…
94efda9 
…2762)

Allow letter spacing in the Input, TextArea, DatePicker, DateTimePicker, DateRangePicker components with common letter spacing tool that is based on three CSS properties - line-height, letter-spacing and word-spacing by setting their default values to the host and inherit them in the native input element.

FIXES: #2755
FIXES: #2641
@petyabegovska petyabegovska moved this to Completed in Planning - Topic Core Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
enhancement New feature or request Planned TOPIC B TOPIC RL
Projects
Planning - Topic Core
Status: Completed
Milestone
1.0.0-rc.12
Development

Successfully merging a pull request may close this issue.

refactor(ui5-input, ui5-textarea, ui5-date-*): allow letter spacing SAP/ui5-webcomponents
2 participants
@ilhan007 @pankajpandey01