Skip to content

ui5-table: pressing blank key or enter key can't trigger row-click event #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GongRichard opened this issue Mar 15, 2021 · 2 comments · Fixed by #2954
Closed

ui5-table: pressing blank key or enter key can't trigger row-click event #2944

GongRichard opened this issue Mar 15, 2021 · 2 comments · Fixed by #2954

Comments

@GongRichard
Copy link

Describe the bug
Pressing blank key or enter key can't trigger row-click event.

To reproduce
Steps to reproduce the behavior:

  1. Go to page https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock#/goal-detail?targetUserId=undefined&templateType=tgm&templateId=583&id=11003
  2. click +12 avatar on the right bottom of Goal Alignment section of the page
  3. use tab key to select one table row, then pressing blank or enter key. It won't trigger row-click event.
    If you use mouse to click the table row, it will trigger row-click event.

Expected behavior
pressing blank key or enter key should trigger row-click event.

Context

  • UI5 Web Components version: 0.29.7
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}
@d3xter666
Copy link
Contributor

According to the documentation, it is fired when a row is clicked.

This should be handled as a feature request for adding a semantic press event

@d3xter666 d3xter666 removed their assignment Mar 15, 2021
@ilhan007 ilhan007 self-assigned this Mar 17, 2021
ilhan007 added a commit that referenced this issue Mar 17, 2021
Start firing row-click upon ENTER/SPACE

FIXES: #2944
ilhan007 added a commit that referenced this issue Mar 17, 2021
Start firing row-click upon ENTER/SPACE

FIXES: #2944
@ilhan007
Copy link
Member

The fix will be included in the next 0.29 patch

ilhan007 added a commit that referenced this issue Mar 18, 2021
Start firing row-click upon ENTER/SPACE

FIXES: #2944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants