Skip to content

AvatarGroup VD deviations #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilhan007 opened this issue Apr 29, 2021 · 0 comments · Fixed by #3252
Closed

AvatarGroup VD deviations #3197

ilhan007 opened this issue Apr 29, 2021 · 0 comments · Fixed by #3252
Assignees
@nnaydenow
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@ilhan007
Copy link
Member

ilhan007 commented Apr 29, 2021 •
edited
Loading

Describe the bug

  1. Distance between avatars in size M type “Group”
  • spec -1.625rem,
  • actual -1.620rem,
  1. Distance between avatars in size “XL” type group
  • spec - 2.75rem
  • actual - 2.7rem
  1. In HCB/HCW themes the “+99” button text is cut off

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/AvatarGroup/

Tester
@PetyaMarkovaBogdanova

Responsible Team
@SAP/ui5-webcomponents-topic-p
@ilhan007 ilhan007 added bug This issue is a bug in the code Release Testing Medium Prio TOPIC P labels Apr 29, 2021
@nnaydenow nnaydenow self-assigned this May 14, 2021
@nnaydenow nnaydenow mentioned this issue May 14, 2021
Merged
ilhan007 pushed a commit that referenced this issue May 14, 2021
@nnaydenow
fix(ui5-avatar-group): visual design deviations (#3252)
49639e5 
First and second deviations were cause because IE11 support. It was rounding incorrectly floated values.
The Third issue comes from base padding of ui5-button which is now removed in the context of overflow button in ui5-avatar-group

Fixes: #3197
hristop pushed a commit that referenced this issue May 18, 2021
@nnaydenow @hristop
fix(ui5-avatar-group): visual design deviations (#3252)
f717684 
First and second deviations were cause because IE11 support. It was rounding incorrectly floated values.
The Third issue comes from base padding of ui5-button which is now removed in the context of overflow button in ui5-avatar-group

Fixes: #3197
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnaydenow nnaydenow

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-avatar-group): visual design deviations
2 participants
@ilhan007 @nnaydenow