fix(ui5-avatar-group): visual design deviations #3252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
approved these changes
May 14, 2021
hristop
pushed a commit
that referenced
this pull request
May 18, 2021
First and second deviations were cause because IE11 support. It was rounding incorrectly floated values. The Third issue comes from base padding of ui5-button which is now removed in the context of overflow button in ui5-avatar-group Fixes: #3197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and second deviations were cause because IE11 support. It was rounding incorrectly floated values.
The Third issue comes from base padding of ui5-button which is now removed in the context of overflow button in ui5-avatar-group
Fixes: #3197