Skip to content

Card: A11y issue #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 4 tasks
ericchan1983 opened this issue Jun 17, 2021 · 1 comment · Fixed by #3464
Closed
1 of 4 tasks

Card: A11y issue #3439

ericchan1983 opened this issue Jun 17, 2021 · 1 comment · Fixed by #3464
Assignees

Comments

@ericchan1983
Copy link

ericchan1983 commented Jun 17, 2021

Bug Description

axe devtool reports an issue for Card component.

  • Ensures role attribute has an appropriate value for the element

Expected Behavior

axe devtool should not report a11y issues for the Card component.

Steps to Reproduce

  1. Install axe devtool (https://chrome.google.com/webstore/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd)
  2. Go to https://y005t.csb.app/
  3. Run automatic scan using axe devtool

Isolated Example

https://codesandbox.io/s/awesome-shadow-y005t?file=/src/App.js

Context

  • UI5 Web Components version: 0.31.6
  • OS/Platform: macOS
  • Browser: Chrome
  • Affected component: Card

Log Output / Stack Trace / Screenshots

image

Priority

  • Low
  • Medium
  • High
  • Very High
@georgimkv georgimkv self-assigned this Jun 18, 2021
@georgimkv georgimkv added the ACC label Jun 18, 2021
@georgimkv
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-rd

There's an accessibility concern with the ui5-card's role="group" on the content slot.
In the wiki pages, it is specified that the section element, should indeed have role="group", but this AXE tool reports it as "not allowed". Could you take a look?

https://codesandbox.io/s/ui5-webcomponents-forked-olxxq?file=/index.html

Regards,
Georgi

@georgimkv georgimkv removed their assignment Jun 18, 2021
@GerganaKremenska GerganaKremenska self-assigned this Jun 21, 2021
ilhan007 pushed a commit that referenced this issue Jun 23, 2021
Section tag `<section>` does not support role='group', replace it with `<div>`

Fixes: #3439
Closes: #3439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants