Skip to content

[ui5-table] TableCell: Text not selectable in Firefox/Safari #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goodefroi opened this issue Jul 7, 2021 · 4 comments · Fixed by #3568
Closed

[ui5-table] TableCell: Text not selectable in Firefox/Safari #3494

goodefroi opened this issue Jul 7, 2021 · 4 comments · Fixed by #3568
Assignees
Labels
bug This issue is a bug in the code Medium Prio RBSC Table TOPIC RL

Comments

@goodefroi
Copy link

Describe the bug
While Chrome allows you to select text in tables just fine, Firefox and Safari won't, even with user-select set to text. This problem ist most likely related to this upstream issue; however, the mentioned workaround using <span> tags does not appear to work with the React wrapper.

Isolated Example
Isolated example on codesandbox.io.

Expected behavior
Text selection works as it would with standard text in Chrome, Firefox, and Safari.

UI5 Web Components for React Information
@ui5/webcomponents version: 1.0.0-rc14
@ui5/webcomponents-react version: 0.16.6
Operating System: macOS 11.4
Browsers: Chrome 91, Firefox 89, Safari 14.1

@Lukas742
Copy link
Collaborator

Lukas742 commented Jul 7, 2021

Hi @goodefroi

the workaround seems to be only functioning with Chromium based browsers, since this is also applying for pure webcomponents (see this codesandbox for reference), I'm going to forward this issue to our UI5 Webcomponents colleagues.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jul 7, 2021
@georgimkv georgimkv self-assigned this Jul 12, 2021
@georgimkv georgimkv added bug This issue is a bug in the code Medium Prio TOPIC RL labels Jul 12, 2021
@georgimkv
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-rd
This issue is about not being able to select text in the component.

There exists a workaround which was good enough for the last time this issue came up in #1163.
The workaround was - wrap the text in a span element and you can now select the text, but only in Chrome.
Sample with and without the span: https://codesandbox.io/s/ui5-webcomponents-forked-33cvy?file=/index.html

Can you see how this issue can be fixed?

Kind regards,
Georgi

@georgimkv georgimkv removed their assignment Jul 12, 2021
@niyap niyap assigned niyap and unassigned niyap Jul 21, 2021
@AndrianStoikov
Copy link

Hello,

Is it possible to take a look at this issue? We at RBSC hit it as well.

Best regards,
Andy

@ilhan007
Copy link
Member

ilhan007 commented Aug 4, 2021

Hello @goodefroi the fix has been released with 1.0.0-rc.15.

Note: there are a lot of breaking changes that have to be adopted before upgrading to RC.15
See the BREAKING_CHANGE section: https://github.com/SAP/ui5-webcomponents/releases/tag/v1.0.0-rc.15

@nikolay-kolarov nikolay-kolarov changed the title TableCell: Text not selectable in Firefox/Safari [ui5-table] TableCell: Text not selectable in Firefox/Safari Feb 16, 2022
@hristop hristop added the Table label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio RBSC Table TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

9 participants