Skip to content

[ui5-table] Table: The space key doesn't work inside the table #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ezuti opened this issue Jul 15, 2021 · 3 comments
Closed

[ui5-table] Table: The space key doesn't work inside the table #3517

Ezuti opened this issue Jul 15, 2021 · 3 comments
Labels
bug This issue is a bug in the code Medium Prio Table TOPIC RL

Comments

@Ezuti
Copy link

Ezuti commented Jul 15, 2021

Describe the bug
If an input is inside a Table, the space key doesn't work. When listening to the keyPress e, event listener can see that it is not triggered by the space key.

Isolated Example
https://codesandbox.io/s/competent-dijkstra-dqmp5?file=/src/App.js

To Reproduce
Steps to reproduce the behavior:

  1. Go to the input under "Input in ui5 table" or "TextArea in ui5 table"
  2. Open the console
  3. Try to write a space or a sentence with a space (you can then try outside the Table)
  4. See error: The space doesn't appear in the selected component and in the console, the space key doesn't trigger keypress

Expected behavior
A space should appear in the text

Screenshots

UI5 Web Components for React Information
@ui5/webcomponents version:1.0.0-rc.14 - latest
@ui5/webcomponents-react version: 0.17.0 - latest
Operating System: Windows 10
Browser: Chrome

Additional context

@Lukas742
Copy link
Collaborator

Lukas742 commented Jul 19, 2021

Hi @Ezuti

thanks for creating this issue. Since it's reproducible with plain web-components (see this codeSandbox), I'm going to forward it to our UI5 Web Components colleagues.

Not 100% sure, but I guess the cause is that the row-selection via space key is overwriting the default key event.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jul 19, 2021
@ilhan007
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl this issue is most probably

duplicate of: #3390
and fixed with: #3393

Could you confirm and close if this is the case?

@ilhan007 ilhan007 added TOPIC RL Medium Prio bug This issue is a bug in the code labels Jul 23, 2021
@niyap
Copy link
Contributor

niyap commented Jul 23, 2021

Hello @Ezuti,

Thanks for sharing your findings!

As Ilhan has mentioned, the issue is already known and fixed. It will be available with the next release.

Kind Regards,
Niya

@niyap niyap closed this as completed Jul 23, 2021
@nikolay-kolarov nikolay-kolarov changed the title Table: The space key doesn't work inside the table [ui5-table] Table: The space key doesn't work inside the table Feb 16, 2022
@hristop hristop added the Table label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio Table TOPIC RL
Projects
Status: Completed
Development

No branches or pull requests

5 participants