Skip to content

[ui5-table] Input and TextArea: Space not being computed inside table #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willianba opened this issue Jun 2, 2021 · 2 comments · Fixed by #3393
Closed

[ui5-table] Input and TextArea: Space not being computed inside table #3390

willianba opened this issue Jun 2, 2021 · 2 comments · Fixed by #3393
Assignees
Labels
bug This issue is a bug in the code Medium Prio Table TOPIC RL

Comments

@willianba
Copy link

Describe the bug
I put an Input and a TextArea inside a Table and these components are not processing spaces, just plain text.

Isolated Example
https://codesandbox.io/s/elegant-shape-q1qbm

To Reproduce
Steps to reproduce the behavior:

  1. Go to the input field in the codebox example
  2. Try to write something with space

Expected behavior
The word to be as you want. Example "hello world" instead of "helloworld".

UI5 Web Components for React Information
@ui5/webcomponents version: 1.0.0-rc.14
@ui5/webcomponents-react version: 0.16.2
Operating System: macOS Big Sur 11.4
Browser: Vivaldi 3.8.2259.42

Additional context
I tried to roll back both versions of webcomponents and webcomponents-react. I am currently on webcomponents: 1.0.0-rc.11 and webcomponents-react: 0.13.11. I don't know exactly what causes the fix, but with these versions, the input is working as expected.

@MarcusNotheis
Copy link
Collaborator

Hey @willianba,
thanks for reporting! As all affected components are developed in the UI5 Web Components Repository, I'll forward your issue.

For the Web Components Colleagues: This is also reproducible using "plain" UI5 Web Components: https://codesandbox.io/s/silly-gauss-7y1bc?file=/src/App.js

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Jun 4, 2021
@dobrinyonkov dobrinyonkov self-assigned this Jun 4, 2021
@dobrinyonkov dobrinyonkov added bug This issue is a bug in the code Medium Prio TOPIC RL labels Jun 4, 2021
@dobrinyonkov
Copy link
Contributor

dobrinyonkov commented Jun 4, 2021

Hello @SAP/ui5-webcomponents-topic-rl,

it is not possible to write whitespace to the ui5-input when it is nested in a table.

This issue is caused by the TableRow and its keydown handler. The default bahavior of the space event is prevented.

Kind Regards,
Dobrin

@niyap niyap self-assigned this Jun 4, 2021
@dobrinyonkov dobrinyonkov removed their assignment Jun 4, 2021
@MapTo0 MapTo0 assigned MapTo0 and unassigned niyap Jun 4, 2021
MapTo0 added a commit that referenced this issue Jun 4, 2021
@nikolay-kolarov nikolay-kolarov changed the title Input and TextArea: Space not being computed inside table [ui5-table] Input and TextArea: Space not being computed inside table Feb 16, 2022
@hristop hristop added the Table label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio Table TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

6 participants