Skip to content

[SF][UI5-Input][ui5-table][BUG][Urgent][0.31.22] Space can not be entered into ui5-input if ui5-input is wrapped with ui5-table-row component #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfsf-xweb-sh opened this issue Nov 19, 2021 · 4 comments
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF Table TOPIC RL

Comments

@sfsf-xweb-sh
Copy link

sfsf-xweb-sh commented Nov 19, 2021

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.

The version of ui5-webcomponent is 0.31.22

Issue:
Space can not be entered into ui5-input if ui5-input is wrapped with ui5-table-row component

Expected Behavior:
Space can be entered into ui5-input if ui5-input is wrapped with ui5-table-row component

The below code in ui5-table-row caused this issue

_onkeydown(event) {
		if (isEnter(event)) {
			this.fireEvent("row-click", { row: this });
		}

		if (isSpace(event)) {
			event.preventDefault();
		}
	}
@IlianaB IlianaB self-assigned this Nov 19, 2021
@IlianaB IlianaB added bug This issue is a bug in the code High Prio SAP SF TOPIC RL labels Nov 19, 2021
@IlianaB
Copy link
Member

IlianaB commented Nov 19, 2021

Hello @SAP/ui5-webcomponents-topic-rl I am forwarding this issue to you, because in ui5-webcomponent version 0.31.22 Space can not be entered into ui5-input, if ui5-input is wrapped with ui5-table-row component: https://codesandbox.io/s/ui5-webcomponents-forked-2ynvz?file=/index.html

It seems to already be fixed in 0.33.

@IlianaB IlianaB removed their assignment Nov 19, 2021
@d3xter666 d3xter666 self-assigned this Nov 22, 2021
@d3xter666
Copy link
Contributor

Hi @sfsf-xweb-sh ,

This is a duplicate with: #3390
It's already fixed with v0.33.0

Cheers

@d3xter666 d3xter666 reopened this Nov 22, 2021
@d3xter666 d3xter666 assigned niyap and unassigned d3xter666 Nov 22, 2021
@sfsf-xweb-sh
Copy link
Author

sfsf-xweb-sh commented Nov 23, 2021

Hi @IlianaB @d3xter666

We must use SF version of UI5-WebComponent.
Can you downport this fix into 0.31.x version ?

We will patch this fix to b2111 version of our project, so we should have a 0.31.x version of ui5 webcomponent

Thanks

@niyap
Copy link
Contributor

niyap commented Nov 23, 2021

Hello @sfsf-xweb-sh,

The fix is downported in 0.31 with the following commit: f891e9d

Kind Regards,
Niya

@niyap niyap closed this as completed Nov 23, 2021
@nikolay-kolarov nikolay-kolarov changed the title [SF][UI5-Input][BUG][Urgent][0.31.22] Space can not be entered into ui5-input if ui5-input is wrapped with ui5-table-row component [SF][UI5-Input][ui5-table][BUG][Urgent][0.31.22] Space can not be entered into ui5-input if ui5-input is wrapped with ui5-table-row component Feb 16, 2022
@hristop hristop added the Table label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF Table TOPIC RL
Projects
Status: Completed
Development

No branches or pull requests

5 participants