Skip to content

MultiComboBox - Deleting items should be possible with backspace #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brodo opened this issue Sep 4, 2019 · 0 comments · Fixed by #793
Closed

MultiComboBox - Deleting items should be possible with backspace #766

brodo opened this issue Sep 4, 2019 · 0 comments · Fixed by #793
Assignees
@MapTo0
Labels
approved This issue is approved bug This issue is a bug in the code

Comments

@brodo
Copy link
Contributor

brodo commented Sep 4, 2019

Is your feature request related to a problem? Please describe.
Deleting a value in a MultiComboBox can only be done using the mouse by clicking on the cross symbol in the item.

Describe the solution you'd like
When the cursor is in the textbox, backspace should delete the last item before the cursor.
MultiCombobox Delete
When I press backspace here, 'UI5' should be deleted.

Describe alternatives you've considered
Leave it as it is or use the delete key (both non-intuitive IMHO)
@fifoosid fifoosid added approved This issue is approved bug This issue is a bug in the code labels Sep 4, 2019
MapTo0 added a commit that referenced this issue Sep 25, 2019
@MapTo0
refactor: align all inputs to use same CSS for styling
91d8987 
- all input like elements such as Input, MultiComboBox, Select use the same CSS for styling host
- all icons than needs to be styled as input icons have a common CSS - InputIcon.css
- users can now overstyle all input elements by setting styles to host
- fixes tiny bug in Select when Picker is open - icon background color should be pressed
- adds a better keyboard handling for MultiComboBox

FIXES: #766
@MapTo0 MapTo0 mentioned this issue Sep 25, 2019
Merged
@MapTo0 MapTo0 self-assigned this Sep 26, 2019
MapTo0 added a commit that referenced this issue Sep 30, 2019
@MapTo0
refactor: align all inputs to use same CSS for styling (#793)
3f26f2c 
- all input like elements such as Input, MultiComboBox, Select use the same CSS for styling host
- all icons than needs to be styled as input icons have a common CSS - InputIcon.css
- users can now overstyle all input elements by setting styles to host
- fixes tiny bug in Select when Picker is open - icon background color should be pressed
- adds a better keyboard handling for MultiComboBox

FIXES: #766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MapTo0 MapTo0

Labels
approved This issue is approved bug This issue is a bug in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: align all inputs to use same CSS for styling SAP/ui5-webcomponents
3 participants
@brodo @MapTo0 @fifoosid