Skip to content

Allow opening BarcodeScannerDialog with 'open' property like Dialog #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
sadie100 opened this issue Jan 10, 2024 · 3 comments
Closed
1 task done

Allow opening BarcodeScannerDialog with 'open' property like Dialog #8072

sadie100 opened this issue Jan 10, 2024 · 3 comments
Assignees
@jdichev @dobrinyonkov
Labels
feature request TOPIC P
Milestone
1.24.0

Comments

@sadie100
Copy link

sadie100 commented Jan 10, 2024 •
edited
Loading

Is your feature request related to a problem?

Dialog can be opened with 'open' property and is recommended since 0.22.0, as the document says : https://sap.github.io/ui5-webcomponents-react/?path=/docs/modals-popovers-dialog--docs

But BarcodeScannerDialog, which is new feature of 1.24.0, allows only ref to open the dialog.
It's not consistent, and is giving confession to old users.

Describe the solution you'd like

Please add 'open' property in BarcodeScannerDialog and allows opening/closing the component using that property.

Describe alternatives you've considered

No response

Additional Context

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Hi @sadie100

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jan 10, 2024
@kgogov kgogov self-assigned this Jan 10, 2024
@kgogov
Copy link
Member

kgogov commented Jan 10, 2024

Hello @SAP/ui5-webcomponents-topic-p,

Please, take a look at this feature request.

Best,
Konstantin

@kgogov kgogov removed their assignment Jan 10, 2024
@dobrinyonkov dobrinyonkov self-assigned this Jan 26, 2024
@dobrinyonkov
Copy link
Contributor

Internal Reference: BGSOFUIPIRIN-6449

@jdichev jdichev self-assigned this Feb 7, 2024
@kgogov kgogov mentioned this issue Feb 20, 2024
Merged
@dobrinyonkov dobrinyonkov added this to the 1.24.0 milestone Mar 6, 2024
kgogov added a commit that referenced this issue Mar 13, 2024
@kgogov
feat(ui5-barcode-scanner-dialog): add 'open' property (#8316)
8f59d16 
* feat(ui5-barcode-scanner-dialog): add 'open' property

This change introduces a new `open` property to the
`ui5-barcode-scanner-dialog` component, enhancing the control over the
dialog's visibility. This feature aligns with the behavior of other
similar components, providing a more consistent user experience.

Related: #8072
@kgogov kgogov closed this as completed Mar 13, 2024
nnaydenow pushed a commit that referenced this issue Mar 20, 2024
@kgogov
feat(ui5-barcode-scanner-dialog): add 'open' property (#8316)
ce008cc 
* feat(ui5-barcode-scanner-dialog): add 'open' property

This change introduces a new `open` property to the
`ui5-barcode-scanner-dialog` component, enhancing the control over the
dialog's visibility. This feature aligns with the behavior of other
similar components, providing a more consistent user experience.

Related: #8072
@petyabegovska petyabegovska moved this to Completed in Planning - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdichev jdichev

@dobrinyonkov dobrinyonkov

Labels
feature request TOPIC P
Projects
Planning - Topic P
Status: Completed
Milestone
1.24.0
Development

No branches or pull requests
5 participants
@jdichev @Lukas742 @dobrinyonkov @kgogov @sadie100