Skip to content

[IllustratedMessage]: Layout problems #8490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ej612 opened this issue Mar 20, 2024 · 4 comments · Fixed by #8566
Closed

[IllustratedMessage]: Layout problems #8490

ej612 opened this issue Mar 20, 2024 · 4 comments · Fixed by #8566
Assignees
Labels
bug This issue is a bug in the code SAP Analytics Cloud SAP Analytics Cloud TOPIC P

Comments

@ej612
Copy link
Contributor

ej612 commented Mar 20, 2024

Bug Description

In v1.23.1, there seems to be something wrong with the IllustratedMessage:

illustrated1

size={IllustrationMessageSize.Dot} doesn't seem to work right, either:
illustrated2

Isolated Example

import {
  Dialog,
  IllustratedMessage,
  IllustrationMessageSize,
} from '@ui5/webcomponents-react';
import '@ui5/webcomponents-fiori/dist/illustrations/EmptyList.js';

function App() {
  return (
    <Dialog
      open={true}
      resizable={true}
      draggable={true}
      style={{
        height: '600px',
      }}
    >
      <IllustratedMessage
        name="EmptyList"
        titleText={'Your selection is empty.'}
        subtitleText={'Select items from the list.'}
        size={IllustrationMessageSize.Spot}
      />
    </Dialog>
  );
}

export default App;

Possibly related to #5852.

UI5 Web Components Version

1.23.1

Browser

Chrome

@ej612 ej612 added the bug This issue is a bug in the code label Mar 20, 2024
@ej612
Copy link
Contributor Author

ej612 commented Mar 20, 2024

Side note: The story 'With A Dialog' doesn't work in Firefox. When I click on the button, nothing happens and I have this error in the console:
image

@ilhan007
Copy link
Member

Hi @SAP/ui5-webcomponents-topic-p could you follow up.
related issue #5852

@ilhan007 ilhan007 added the SAP Analytics Cloud SAP Analytics Cloud label Mar 22, 2024
@plamenivanov91 plamenivanov91 self-assigned this Mar 22, 2024
@plamenivanov91
Copy link
Contributor

Side note: The story 'With A Dialog' doesn't work in Firefox. When I click on the button, nothing happens and I have this error in the console: image

Hello @ej612 ,

The sample works perfectly fine on the latest Firefox browser
Screenshot 2024-03-28 155316

I'll look into the rest of the issue now.

Regards,
Plamen Ivanov

plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Mar 28, 2024
Recent DOT feature led to improper vertical alignment of Illustrated
Message's SVG when the IM is inside tall container.
Now we make sure both the text and the SVG container are vertically
centered in case of tall container.
Fixes: SAP#8490
plamenivanov91 added a commit that referenced this issue Mar 28, 2024
Recent DOT feature led to improper vertical alignment of Illustrated
Message's SVG when the IM is inside tall container.
Now we make sure both the text and the SVG container are vertically
centered in case of tall container.
Fixes: #8490
@ej612
Copy link
Contributor Author

ej612 commented Mar 28, 2024

Hi @plamenivanov91, thanks a lot for the fix!

The sample works perfectly fine on the latest Firefox browser

I confirm, same here. No idea what the issue was.

ilhan007 pushed a commit that referenced this issue Apr 3, 2024
Recent DOT feature led to improper vertical alignment of Illustrated
Message's SVG when the IM is inside tall container.
Now we make sure both the text and the SVG container are vertically
centered in case of tall container.
Fixes: #8490
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code SAP Analytics Cloud SAP Analytics Cloud TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants