Skip to content

Language configuration does not "set" RTL mode #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pskelin opened this issue Nov 22, 2019 · 0 comments · Fixed by #959
Closed

Language configuration does not "set" RTL mode #957

pskelin opened this issue Nov 22, 2019 · 0 comments · Fixed by #959
Assignees
@ilhan007

Comments

@pskelin
Copy link
Contributor

pskelin commented Nov 22, 2019

Setting the configured language to ?sap-ui-language=he should also apply an RTL configuration. Currently this is not the case.

There should also be a test for this fix.
@ilhan007 ilhan007 self-assigned this Nov 22, 2019
@ilhan007 ilhan007 mentioned this issue Nov 22, 2019
Merged
ilhan007 added a commit that referenced this issue Nov 25, 2019
@ilhan007
chore: add wdio tests for RTL mode (#959)
a5081c1 
FIXES: #957
plamenivanov91 pushed a commit to plamenivanov91/ui5-webcomponents that referenced this issue Nov 27, 2019
@ilhan007 @plamenivanov91
chore: add wdio tests for RTL mode (SAP#959)
d47075b 
FIXES: SAP#957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add wdio tests for RTL mode SAP/ui5-webcomponents
2 participants
@pskelin @ilhan007