Skip to content

fix(ui5-menu-item): remove redundant screen reader announcements #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-menu-item): remove redundant screen reader announcements #11415

wants to merge 1 commit into from

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Apr 25, 2025

Issue 1:

  • The aria-labelledby reference to the ui5-menu-item has wrong text.

Issue 2:

  • The aria-labelledby reference to the ui5-menu-item has redundant text.

Solution:

  • Use the text provided from the underlying ui5-list-item for an aria-labelledby.

Fixes: #11380
Fixes: #11405

@unazko unazko requested review from hinzzx and nnaydenow April 25, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinzzx hinzzx hinzzx approved these changes

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@unazko @hinzzx