-
Notifications
You must be signed in to change notification settings - Fork 275
feat(ui5-timepicker): implement new component #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ilhan007
merged 90 commits into
SAP:master
from
tsanislavgatev:timepicker-implementation
Mar 24, 2020
Merged
Changes from 79 commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
767525a
feat: implement create control script
tsanislavgatev 2f2ba11
fix: create control script pr notes fix
tsanislavgatev f722bb6
add console error on empty string for a name of component
tsanislavgatev 1357c13
solve conflict
tsanislavgatev 849e594
master update
tsanislavgatev bd9bf48
removed hungarian notation
tsanislavgatev 4b82ba5
removed old component creation snippet file
tsanislavgatev f77bfb6
feat(ui5-tabcontainer): acc update
tsanislavgatev 8d26917
merge conflict solve
tsanislavgatev a9235f7
merge conflict tags solve
tsanislavgatev fdd2118
feat(ui5-tabcontainer): update ACC of header and content
tsanislavgatev af2422c
feat(ui5-tabcontainer): update ACC of header and content
tsanislavgatev 23be11a
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 4850ce6
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 3c71085
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 067dbaa
feat:(ui5-datepicker): update ACC of the component and input included
tsanislavgatev 9d4f2db
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 874d752
Updating with comments from PR
tsanislavgatev 6d1dc16
Update with notes from PR
tsanislavgatev 5ed53a2
Improve of get methods for acc in input
tsanislavgatev 70b5104
update with comments from pr
tsanislavgatev d6598da
changing the place of input parent information
tsanislavgatev 0c842f7
update escaping information repeating
tsanislavgatev 9f686aa
merge commit
tsanislavgatev cf56bf0
merge commit
tsanislavgatev 4e329fa
fix(ui5-daypicker): Separating datepicker click handling to mousedown…
tsanislavgatev 49a4436
On press between date cells the pop up no longer closes
tsanislavgatev 44ecfa7
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 4967eeb
Merge remote-tracking branch 'upstream/master'
tsanislavgatev e35150d
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 9207a47
alpha timepicker and sliders version
tsanislavgatev 4614239
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 4d896b4
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 08dba30
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 053db11
Arrows added to sliders
tsanislavgatev 7e496c8
the input now works with am pm
tsanislavgatev f5f0f46
Added theme support and minor slider fixes
tsanislavgatev f27f494
Code cleaning, theming separation, colors using vars
tsanislavgatev a32ecf4
minor fixes
tsanislavgatev 6e1fead
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 70b9966
master merge
tsanislavgatev 7ecce83
Responsive popover support added, mobile view fixed, more functionali…
tsanislavgatev 03a2640
prepare for review
tsanislavgatev 4515cc2
lint fixes
tsanislavgatev 3a27451
removed redundant comments
tsanislavgatev d73d28b
fixed wheel handler
tsanislavgatev 8fc1227
Slider before test fix
tsanislavgatev e57d15d
Added tests for timepicker and value state change
tsanislavgatev a6843a5
Comments fixed and playground sample added
tsanislavgatev 35a8655
Fixed periods cldr and default time format
tsanislavgatev 7c9af87
parameters changed in css base for slider
tsanislavgatev 1ff713b
Merge remote-tracking branch 'upstream/master'
tsanislavgatev ddea451
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 4429a6c
change name from slider to wheelslider
tsanislavgatev f8d33a0
Rename fixes
tsanislavgatev 08907b0
Added new template popoverfor timepicker
tsanislavgatev efcb720
Test fixed
tsanislavgatev 39c1bca
lint fix
tsanislavgatev 3d26ff6
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 91b8165
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 0ad9588
merged master
tsanislavgatev 68d16a5
removed unstable test
tsanislavgatev d91c0cb
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 2d59ecf
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev dd15ef6
Aligned with the new changes
tsanislavgatev b1fd733
Comments fixes
tsanislavgatev 5ee986a
Merge branch 'master' into timepicker-implementation
tsanislavgatev 77646af
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 7ceb9cb
merge master
tsanislavgatev bba4c30
merge master
tsanislavgatev 0903256
merge master
tsanislavgatev b936b09
fixed test with arrow buttons
tsanislavgatev 4d6341b
pulling original repo master
tsanislavgatev fef0b2b
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev db288bf
Changes for new merge
tsanislavgatev 879142f
Fixed problem with not closing tag on outfocus close of the picker
tsanislavgatev 05c74ad
Added more samples to test page, and changes ie unsupported function
tsanislavgatev d4d7ea3
Comments fixing
tsanislavgatev 82a99b2
Comments fixes
tsanislavgatev c64cded
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 0782183
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 15c9023
merge and comment fix
tsanislavgatev 3650110
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 78f8bbe
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 3418599
VD alignment
tsanislavgatev c7cf6ea
Merge remote-tracking branch 'upstream/master'
tsanislavgatev 2715174
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev 9a38a03
comments and mege
tsanislavgatev b5e601d
Title removed
tsanislavgatev e3d6afe
ie styling fix
tsanislavgatev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<div id="{{this._id}}" formatPattern="{{formatPattern}}" class="ui5-timepicker-root" @keydown="{{_ontimepickerkeydown}}"> | ||
tsanislavgatev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<ui5-input | ||
id="{{_id}}-inner" | ||
value="{{value}}" | ||
?disabled="{{disabled}}" | ||
?readonly="{{readonly}}" | ||
value-state="{{valueState}}" | ||
@ui5-change="{{_handleInputChange}}" | ||
@ui5-input="{{_handleInputLiveChange}}" | ||
> | ||
{{#unless readonly}} | ||
<ui5-icon | ||
ilhan007 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
slot="icon" | ||
name="time-entry-request" | ||
tsanislavgatev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
tabindex="-1" | ||
show-tooltip | ||
@click="{{togglePicker}}" | ||
input-icon | ||
?pressed="{{_isPickerOpen}}" | ||
class="ui5-timepicker-input-icon-button" | ||
></ui5-icon> | ||
ilhan007 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{{/unless}} | ||
</ui5-input> | ||
</div> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.