Skip to content

feat(ui5-timepicker): implement new component #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 90 commits into from
Mar 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
767525a
feat: implement create control script
tsanislavgatev Aug 26, 2019
2f2ba11
fix: create control script pr notes fix
tsanislavgatev Aug 26, 2019
f722bb6
add console error on empty string for a name of component
tsanislavgatev Aug 28, 2019
1357c13
solve conflict
tsanislavgatev Aug 28, 2019
849e594
master update
tsanislavgatev Aug 28, 2019
bd9bf48
removed hungarian notation
tsanislavgatev Aug 28, 2019
4b82ba5
removed old component creation snippet file
tsanislavgatev Aug 28, 2019
f77bfb6
feat(ui5-tabcontainer): acc update
tsanislavgatev Aug 30, 2019
8d26917
merge conflict solve
tsanislavgatev Aug 30, 2019
a9235f7
merge conflict tags solve
tsanislavgatev Aug 30, 2019
fdd2118
feat(ui5-tabcontainer): update ACC of header and content
tsanislavgatev Aug 30, 2019
af2422c
feat(ui5-tabcontainer): update ACC of header and content
tsanislavgatev Aug 30, 2019
23be11a
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Aug 30, 2019
4850ce6
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Aug 30, 2019
3c71085
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Aug 30, 2019
067dbaa
feat:(ui5-datepicker): update ACC of the component and input included
tsanislavgatev Sep 3, 2019
9d4f2db
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Sep 3, 2019
874d752
Updating with comments from PR
tsanislavgatev Sep 3, 2019
6d1dc16
Update with notes from PR
tsanislavgatev Sep 4, 2019
5ed53a2
Improve of get methods for acc in input
tsanislavgatev Sep 5, 2019
70b5104
update with comments from pr
tsanislavgatev Sep 5, 2019
d6598da
changing the place of input parent information
tsanislavgatev Sep 10, 2019
0c842f7
update escaping information repeating
tsanislavgatev Sep 10, 2019
9f686aa
merge commit
tsanislavgatev Oct 28, 2019
cf56bf0
merge commit
tsanislavgatev Oct 28, 2019
4e329fa
fix(ui5-daypicker): Separating datepicker click handling to mousedown…
tsanislavgatev Oct 28, 2019
49a4436
On press between date cells the pop up no longer closes
tsanislavgatev Oct 28, 2019
44ecfa7
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Dec 5, 2019
4967eeb
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Jan 7, 2020
e35150d
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Jan 15, 2020
9207a47
alpha timepicker and sliders version
tsanislavgatev Jan 23, 2020
4614239
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Jan 23, 2020
4d896b4
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Jan 31, 2020
08dba30
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Jan 31, 2020
053db11
Arrows added to sliders
tsanislavgatev Jan 31, 2020
7e496c8
the input now works with am pm
tsanislavgatev Jan 31, 2020
f5f0f46
Added theme support and minor slider fixes
tsanislavgatev Feb 11, 2020
f27f494
Code cleaning, theming separation, colors using vars
tsanislavgatev Feb 13, 2020
a32ecf4
minor fixes
tsanislavgatev Feb 18, 2020
6e1fead
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Feb 18, 2020
70b9966
master merge
tsanislavgatev Feb 18, 2020
7ecce83
Responsive popover support added, mobile view fixed, more functionali…
tsanislavgatev Feb 24, 2020
03a2640
prepare for review
tsanislavgatev Mar 4, 2020
4515cc2
lint fixes
tsanislavgatev Mar 4, 2020
3a27451
removed redundant comments
tsanislavgatev Mar 4, 2020
d73d28b
fixed wheel handler
tsanislavgatev Mar 4, 2020
8fc1227
Slider before test fix
tsanislavgatev Mar 5, 2020
e57d15d
Added tests for timepicker and value state change
tsanislavgatev Mar 5, 2020
a6843a5
Comments fixed and playground sample added
tsanislavgatev Mar 6, 2020
35a8655
Fixed periods cldr and default time format
tsanislavgatev Mar 9, 2020
7c9af87
parameters changed in css base for slider
tsanislavgatev Mar 9, 2020
1ff713b
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 9, 2020
ddea451
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 9, 2020
4429a6c
change name from slider to wheelslider
tsanislavgatev Mar 9, 2020
f8d33a0
Rename fixes
tsanislavgatev Mar 9, 2020
08907b0
Added new template popoverfor timepicker
tsanislavgatev Mar 9, 2020
efcb720
Test fixed
tsanislavgatev Mar 10, 2020
39c1bca
lint fix
tsanislavgatev Mar 10, 2020
3d26ff6
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 11, 2020
91b8165
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 11, 2020
0ad9588
merged master
tsanislavgatev Mar 11, 2020
68d16a5
removed unstable test
tsanislavgatev Mar 11, 2020
d91c0cb
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 11, 2020
2d59ecf
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 11, 2020
dd15ef6
Aligned with the new changes
tsanislavgatev Mar 11, 2020
b1fd733
Comments fixes
tsanislavgatev Mar 12, 2020
5ee986a
Merge branch 'master' into timepicker-implementation
tsanislavgatev Mar 12, 2020
77646af
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 12, 2020
7ceb9cb
merge master
tsanislavgatev Mar 12, 2020
bba4c30
merge master
tsanislavgatev Mar 12, 2020
0903256
merge master
tsanislavgatev Mar 12, 2020
b936b09
fixed test with arrow buttons
tsanislavgatev Mar 12, 2020
4d6341b
pulling original repo master
tsanislavgatev Mar 13, 2020
fef0b2b
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 13, 2020
db288bf
Changes for new merge
tsanislavgatev Mar 13, 2020
879142f
Fixed problem with not closing tag on outfocus close of the picker
tsanislavgatev Mar 16, 2020
05c74ad
Added more samples to test page, and changes ie unsupported function
tsanislavgatev Mar 16, 2020
d4d7ea3
Comments fixing
tsanislavgatev Mar 17, 2020
82a99b2
Comments fixes
tsanislavgatev Mar 18, 2020
c64cded
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 19, 2020
0782183
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 19, 2020
15c9023
merge and comment fix
tsanislavgatev Mar 19, 2020
3650110
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 20, 2020
78f8bbe
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 20, 2020
3418599
VD alignment
tsanislavgatev Mar 20, 2020
c7cf6ea
Merge remote-tracking branch 'upstream/master'
tsanislavgatev Mar 23, 2020
2715174
Merge branch 'master' of https://github.com/tsanislavgatev/ui5-webcom…
tsanislavgatev Mar 23, 2020
9a38a03
comments and mege
tsanislavgatev Mar 23, 2020
b5e601d
Title removed
tsanislavgatev Mar 23, 2020
e3d6afe
ie styling fix
tsanislavgatev Mar 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/main/bundle.esm.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,13 @@ import TableCell from "./dist/TableCell.js";
import TextArea from "./dist/TextArea.js";
import Timeline from "./dist/Timeline.js";
import TimelineItem from "./dist/TimelineItem.js";
import TimePicker from "./dist/TimePicker.js";
import Title from "./dist/Title.js";
import Toast from "./dist/Toast.js";
import ToggleButton from "./dist/ToggleButton.js";



import List from "./dist/List.js";
import StandardListItem from "./dist/StandardListItem.js";
import CustomListItem from "./dist/CustomListItem.js";
Expand Down
24 changes: 24 additions & 0 deletions packages/main/src/TimePicker.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<div id="{{this._id}}" class="ui5-timepicker-root" @keydown="{{_ontimepickerkeydown}}">
<ui5-input
id="{{_id}}-inner"
value="{{value}}"
?disabled="{{disabled}}"
?readonly="{{readonly}}"
value-state="{{valueState}}"
@ui5-change="{{_handleInputChange}}"
@ui5-input="{{_handleInputLiveChange}}"
>
{{#unless readonly}}
<ui5-icon
slot="icon"
name="time-entry-request"
tabindex="-1"
show-tooltip
@click="{{togglePicker}}"
input-icon
?pressed="{{_isPickerOpen}}"
class="ui5-timepicker-input-icon-button"
></ui5-icon>
{{/unless}}
</ui5-input>
</div>
Loading