Skip to content

fix(ui5-button): make aria-label work for ui5-button #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 24, 2020
Merged

fix(ui5-button): make aria-label work for ui5-button #1445

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bba878a
POC: button aria-label
fifoosid Apr 8, 2020
d5946fd
fix linter
fifoosid Apr 8, 2020
9e1b35c
fix docs
fifoosid Apr 8, 2020
100d2a9
Merge remote-tracking branch 'origin/master' into button-aria-label
vladitasev Apr 13, 2020
fb22b5f
Merge branch 'master' into button-aria-label
fifoosid Apr 13, 2020
3a3de12
Merge branch 'button-aria-label' of https://github.com/SAP/ui5-webcom…
fifoosid Apr 13, 2020
b043435
Merge master branch & resolve merge conflicts
fifoosid Apr 13, 2020
1b923ad
Merge branch 'master' into button-aria-label
fifoosid Apr 14, 2020
4e1156b
Merge remote-tracking branch 'origin/master' into button-aria-label
vladitasev Apr 23, 2020
cbf47d9
fix typo, allow ariaLabel
vladitasev Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/main/src/Button.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
tabindex={{tabIndexValue}}
aria-expanded="{{accInfo.ariaExpanded}}"
aria-controls="{{accInfo.ariaControls}}"
aria-label="{{ariaLabel}}"
title="{{accInfo.title}}"
part="button"
>
Expand Down
12 changes: 12 additions & 0 deletions packages/main/src/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,18 @@ const metadata = {
type: Boolean,
},

/**
* Defines the aria-label attribute for the button
* @type {String}
* @defaultvalue: ""
* @private
* @since 1.0.0-rc.7
*/
ariaLabel: {
type: String,
defaultValue: undefined,
},

/**
* Indicates if the element if focusable
* @private
Expand Down
4 changes: 2 additions & 2 deletions packages/main/test/pages/Button.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
<br/>
<br/>

<ui5-button icon="employee">Action Bar Button</ui5-button>
<ui5-button icon="download"></ui5-button>
<ui5-button icon="download" aria-label="Download application"></ui5-button>
<ui5-button icon="employee" aria-label="Download book">Action Bar Button</ui5-button>
<ui5-button icon="download"></ui5-button>

<br />
Expand Down