Skip to content

ui5-table: design implemented for popped-in columns #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

ui5-table: design implemented for popped-in columns #1726

merged 1 commit into from
Jun 3, 2020

Conversation

vladitasev
Copy link
Contributor

This change fixes two issues:

  • The popin rows had the wrong color until now, and they must be exactly the same color as the normal rows by design
  • When all columns are popped in, since there is no normal row, there is nothing to provide the border. Therefore, the top popin row for the first column of for each group should do it.

closes: #1710

@vladitasev vladitasev merged commit d849bec into master Jun 3, 2020
@vladitasev vladitasev deleted the table-popin-design-fix branch June 3, 2020 10:29
ilhan007 pushed a commit that referenced this pull request Jun 8, 2020
@vladitasev @ilhan007
ui5-table: design implemented for popped-in columns (#1726)
11682a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
for review SAP MDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui-table: design breaks when demand-popin is set for all columns
2 participants
@vladitasev @ilhan007