refactor(ui5-popup): Move more common functionality to Popup.js #1853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Dialog.js
andPopover.js
have a lot in common in theopen/openBy
andclose
methods.The goal of this change is to streamline them, and at the same time make
Popup.js
much more self-sufficient, so that third parties can create custom popups without understanding our low-level APIs such as popup registries, body scroll blocking, etc...Popup.js
:isModal
headerText
,header
andfooter
, only a default slotbeforeContent
andafterContent
Dialog.js
:Popup.js
.hbs
Popover.js
:open
inopenBy
and has noclose
since the code is now inPopup.js
.hbs
closes: #1837
closes: #1836