Skip to content

fix(ui5-select): fix text color of disabled select in hcb/hcw #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2020
Merged

fix(ui5-select): fix text color of disabled select in hcb/hcw #2248

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a736c8
fix(ui5-select): fix text color of disabled select in hcbc/hcw
fifoosid Sep 25, 2020
aae9acf
fix comments
fifoosid Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/main/src/themes/Input.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
pointer-events: none;
background: var(--sapField_ReadOnly_Background);
border-color: var(--sapField_ReadOnly_BorderColor);
-webkit-text-fill-color: var(--sapContent_DisabledTextColor);
color: var(--sapContent_DisabledTextColor);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the latest design, the text color should be --sapField_TextColor (not --sapContent_DisabledTextColor) in Fiori3 HCW and HCB themes in order to see the text, otherwise it is almost unreadable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sapField_TextColor is the default colour, so it is not needed to be set explicitly again.

}

Expand Down