Skip to content

feat(ui5-flexible-column-layout): add start/mid/endColumnAccessibleName properties #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2020
Merged

feat(ui5-flexible-column-layout): add start/mid/endColumnAccessibleName properties #2483

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b863fa2
feat(ui5-flexible-column-layout): implement startColumnAccessibleText…
fifoosid Nov 16, 2020
356097b
fix docs
fifoosid Nov 16, 2020
1a8657a
fix comments
fifoosid Nov 24, 2020
4010391
Merge branch 'master' into fcl-region-acc
fifoosid Nov 30, 2020
85cf159
fix docs
fifoosid Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions packages/fiori/src/FlexibleColumnLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,42 @@ const metadata = {
type: Boolean,
},

/**
* Defines the accessibility text for the <code>startColumn</code> region.
*
* @type {string}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.11
*/
startColumnAccessibleText: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think accessibleName is the correct term, here it is accessibleText. But, I will have to discuss it with responsible team.

type: String,
},

/**
* Defines the accessibility text for the <code>midColumn</code> region.
*
* @type {string}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.11
*/
midColumnAccessibleText: {
type: String,
},

/**
* Defines the accessibility text for the <code>endColumn</code> region.
*
* @type {string}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.11
*/
endColumnAccessibleText: {
type: String,
},

/**
* Defines the component width in px.
*
Expand Down Expand Up @@ -620,15 +656,15 @@ class FlexibleColumnLayout extends UI5Element {
}

get accStartColumnText() {
return this.i18nBundle.getText(FCL_START_COLUMN_TXT);
return this.startColumnAccessibleText || this.i18nBundle.getText(FCL_START_COLUMN_TXT);
}

get accMiddleColumnText() {
return this.i18nBundle.getText(FCL_MIDDLE_COLUMN_TXT);
return this.midColumnAccessibleText || this.i18nBundle.getText(FCL_MIDDLE_COLUMN_TXT);
}

get accEndColumnText() {
return this.i18nBundle.getText(FCL_END_COLUMN_TXT);
return this.endColumnAccessibleText || this.i18nBundle.getText(FCL_END_COLUMN_TXT);
}

get _effectiveLayoutsByMedia() {
Expand Down
7 changes: 6 additions & 1 deletion packages/fiori/test/pages/FCLApp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,12 @@
</ui5-shellbar>

<!--- FLEXIBLE COLUMN LAYOUT -->
<ui5-flexible-column-layout id="fcl">
<ui5-flexible-column-layout
id="fcl"
start-column-accessible-text="Companies list"
mid-column-accessible-text="Products List"
end-column-accessible-text="Product Details"
>
<div class="column" id="startColumn" slot="startColumn">
<ui5-busyindicator id="startBusy">
<div class="ui5-message-page">
Expand Down