Skip to content

feat(ui5-range-slider): focus and keyboard handling implementation #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jan 20, 2021
Merged

feat(ui5-range-slider): focus and keyboard handling implementation #2620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
dfcf104
slider commit
ndeshev Dec 15, 2020
4bbdbb2
Refactoring and comments
ndeshev Dec 21, 2020
2ec805c
feat(ui5-slider)focus and keyboard handling implementation
ndeshev Dec 22, 2020
a07f2f6
Add more tests, refactor value and visual UI updating
ndeshev Dec 29, 2020
a6ced77
Add more keyboard handling tests
ndeshev Dec 29, 2020
e08aefd
Remove log file, update Keys.js
ndeshev Dec 29, 2020
dd5cfac
Complete the test cases covered
ndeshev Dec 29, 2020
ac49721
Restore ResizeHandler Import in SliderBase
ndeshev Dec 29, 2020
92b562f
Merge branch 'master' into slider-focus-and-kbd-handling
ndeshev Jan 4, 2021
374142f
Minor template fixes
ndeshev Jan 4, 2021
ac97242
slider commit
ndeshev Dec 15, 2020
12233d3
Focus and keyboard handling documentation
ndeshev Dec 23, 2020
e7130cc
Add tests for focus and keyboard handling
ndeshev Dec 30, 2020
a6d29c2
Fix rebasing errors
ndeshev Jan 4, 2021
e37920a
Improve code based on the code reviews, fix keyboard handling bugs
ndeshev Jan 9, 2021
35a662b
Merge branch 'master' into rangeslider-focus-keyboard-handling
ndeshev Jan 11, 2021
1154dc5
Fix merge error
ndeshev Jan 11, 2021
171dcf5
Fix click in a range selection close to handle bug, revert back the t…
ndeshev Jan 12, 2021
601e06b
Fix code reviews proposals
ndeshev Jan 18, 2021
f29fa84
Merge remote-tracking branch 'upstream/master' into rangeslider-focus…
ndeshev Jan 18, 2021
f2a6178
Fix calling of the static 'VALUES' getter
ndeshev Jan 18, 2021
4947b1f
Remove getters for private props
ndeshev Jan 20, 2021
e6e073d
Fix the bug in _setAfffectedValueByFocusedElement() introduced in the…
ndeshev Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/src/RangeSlider.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{{>include "./SliderBase.hbs"}}

{{#*inline "handles"}}
<div class="ui5-slider-handle ui5-slider-handle--start" style="{{styles.startHandle}}">
<div class="ui5-slider-handle ui5-slider-handle--start" style="{{styles.startHandle}}" tabindex="{{tabIndex}}" @focusout="{{_onfocusout}}" @focusin="{{_onfocusin}}">
{{#if showTooltip}}
<div class="ui5-slider-tooltip ui5-slider-tooltip--start" style="{{styles.tooltip}}">
<span class="ui5-slider-tooltip-value">{{tooltipStartValue}}</span>
</div>
{{/if}}
</div>
<div class="ui5-slider-handle ui5-slider-handle--end" style="{{styles.endHandle}}">
<div class="ui5-slider-handle ui5-slider-handle--end" style="{{styles.endHandle}}" tabindex="{{tabIndex}}" @focusout="{{_onfocusout}}" @focusin="{{_onfocusin}}">
{{#if showTooltip}}
<div class="ui5-slider-tooltip ui5-slider-tooltip--end" style="{{styles.tooltip}}">
<span class="ui5-slider-tooltip-value">{{tooltipEndValue}}</span>
Expand Down
Loading