fix(ui5-checkbox): vertical misalignment when wrap is true #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- redundant CSS styling is removed which was causing the issue
ilhan007
requested changes
Jan 29, 2021
There was a problem hiding this comment.
Now when you remove this, the alignment when the text is wrapping breaks. I suggest comparing all cases between the local test page and the deployed test page - https://sap.github.io/ui5-webcomponents/master/playground/main/pages/CheckBox/
With the Change (the check mark is vertically centred against the text)
Prior to the change
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
* fix(ui5-checkbox): vertical misalignment when wrap is true - redundant CSS styling is removed which was causing the issue * CheckBox inner is now aligned properly
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
* fix(ui5-checkbox): vertical misalignment when wrap is true - redundant CSS styling is removed which was causing the issue * CheckBox inner is now aligned properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist