fix(ui5-multi-combobox): fix JS error on phone #2795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix JS error thrown on phone (Chrome phone emulator as well). It happens, because the selectedValues array is never declared, but accessed as "this.selectedValues.length" through the "_showAllItemsButtonPressed" getter upon initial rendering. To reproduce the issue you can use Chrome phone emulator and open https://sap.github.io/ui5-webcomponents/master/playground/main/pages/MultiComboBox/ on phone.
ilhan007
changed the title
ilhan007
requested review from
vladitasev,
MapTo0,
niyap and
ivoplashkov
and removed request for
MapTo0 and
vladitasev
MapTo0
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JS error thrown on phone (Chrome phone emulator as well). It happens, because the selectedValues array is never declared, but accessed as "this.selectedValues.length" through the "_showAllItemsButtonPressed" getter upon initial rendering. To reproduce the issue you can use Chrome phone emulator and open https://sap.github.io/ui5-webcomponents/master/playground/main/pages/MultiComboBox/ on phone.