Skip to content

fix(ui5-bar): aria label added depending on the "design" property #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2021
Merged

fix(ui5-bar): aria label added depending on the "design" property #3161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
568dc54
fix(ui5-bar): aria label added depending on the "deisgn" property
unazko Apr 19, 2021
5ff90d4
Lint errors fixed.
unazko Apr 19, 2021
718154b
Aria-labelledby is changed to aria-label.
unazko Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fiori/src/Bar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="ui5-bar-root"
<div class="ui5-bar-root" aria-label="{{accInfo.label}}"
role="toolbar">
<div class="ui5-bar-content-container ui5-bar-startcontent-container">
<slot name="startContent"></slot>
Expand Down
6 changes: 6 additions & 0 deletions packages/fiori/src/Bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ class Bar extends UI5Element {
static get template() {
return BarTemplate;
}

get accInfo() {
return {
"label": this.design,
};
}
}

Bar.define();
Expand Down