Skip to content

refactor(ui5-avatar): rename backgroundColor property to colorScheme #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 18, 2021

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented May 11, 2021

Part of #3107

BREAKING_CHANGE: The backgroundColor property of ui5-avatar is changed to colorScheme

@fifoosid fifoosid mentioned this pull request May 12, 2021
@ilhan007
Copy link
Member

make sure you merge the commit not with "chore" to have it in the release notes as it is breaking change

@fifoosid fifoosid changed the title chore(ui5-avatar): rename backgroundColor property to backgroundDesign fix(ui5-avatar): rename backgroundColor property to backgroundDesign May 12, 2021
ilhan007
ilhan007 previously approved these changes May 12, 2021
@ilhan007 ilhan007 dismissed their stale review May 12, 2021 08:31

dismiss for a second

@ilhan007 ilhan007 requested a review from a team May 12, 2021 11:07
dobrinyonkov
dobrinyonkov previously approved these changes May 12, 2021
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnaydenow has concerns about the new name

@fifoosid fifoosid requested a review from ilhan007 May 13, 2021 12:49
@ilhan007 ilhan007 changed the title fix(ui5-avatar): rename backgroundColor property to backgroundDesign fix(ui5-avatar): rename backgroundColor property to colorScheme May 14, 2021
@ilhan007 ilhan007 changed the title fix(ui5-avatar): rename backgroundColor property to colorScheme refactor(ui5-avatar): rename backgroundColor property to colorScheme May 14, 2021
@ilhan007 ilhan007 merged commit a3a3a11 into master May 18, 2021
@ilhan007 ilhan007 deleted the avatar-background-design branch May 18, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants