feat(ui5-li-custom, ui5-li, ui5-li-groupheader): add accessibleName property #3269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine with screen readers and looks good from accessibility POV. |
fifoosid
suggested changes
May 31, 2021
|
Hi @fifoosid , We add this property to each component because it is not confirmed to other components that extends the ListItem. We are doing this to not affect them. |
fifoosid
approved these changes
May 31, 2021
ilhan007
pushed a commit
that referenced
this pull request
Jun 1, 2021
ilhan007
pushed a commit
that referenced
this pull request
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new accessibleName attribute which allows to have additional custom information of each list item.
Closes: #3014