Skip to content

feat: expose dist paths as root paths via package.json export field #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2021
Merged

feat: expose dist paths as root paths via package.json export field #3274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ee3e9f
expose dist paths as root paths via package.json export field
pskelin May 19, 2021
34a6166
add .port to exports as the tests use require to read it
pskelin May 19, 2021
89a1c09
add src folder to exports for template includes resolving
pskelin May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/base/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import UI5Element from "./src/UI5Element.js";
import UI5Element from "./dist/UI5Element.js";

export default UI5Element;
export { UI5Element };
7 changes: 7 additions & 0 deletions packages/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@
"url": "https://github.com/SAP/ui5-webcomponents.git",
"directory": "packages/base"
},
"exports": {
".": "./index.js",
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./bundle.esm.js": "./bundle.esm.js",
"./*": "./dist/*"
},
"scripts": {
"clean": "nps clean",
"lint": "nps lint",
Expand Down
10 changes: 10 additions & 0 deletions packages/fiori/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@
"sapui5",
"ui5"
],
"exports": {
"./.port": "./.port",
"./src/*": "./src/*",
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./bundle.esm.js": "./bundle.esm.js",
"./bundle.es5.js": "./bundle.es5.js",
"./bundle.common.js": "./bundle.common.js",
"./*": "./dist/*"
},
"scripts": {
"clean": "wc-dev clean",
"lint": "wc-dev lint",
Expand Down
5 changes: 5 additions & 0 deletions packages/icons-tnt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
"sapui5",
"ui5"
],
"exports": {
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./*": "./dist/*"
},
"scripts": {
"clean": "wc-dev clean",
"build": "wc-dev build",
Expand Down
5 changes: 5 additions & 0 deletions packages/icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
"sapui5",
"ui5"
],
"exports": {
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./*": "./dist/*"
},
"scripts": {
"clean": "wc-dev clean",
"build": "wc-dev build",
Expand Down
5 changes: 5 additions & 0 deletions packages/localization/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
"url": "https://github.com/SAP/ui5-webcomponents.git",
"directory": "packages/localization"
},
"exports": {
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./*": "./dist/*"
},
"scripts": {
"clean": "nps clean",
"lint": "nps lint",
Expand Down
2 changes: 1 addition & 1 deletion packages/main/bundle.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getAssetsPath, setAssetsPath } from "@ui5/webcomponents-base/dist/config/AssetsPath.js";
// setAssetsPath("/my-resources/");

import { addCustomCSS, attachThemeLoaded, detachThemeLoaded } from "@ui5/webcomponents-base/dist/Theming";
import { addCustomCSS, attachThemeLoaded, detachThemeLoaded } from "@ui5/webcomponents-base/dist/Theming.js";


// Calendars
Expand Down
10 changes: 10 additions & 0 deletions packages/main/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@
"create-ui5-element": "wc-create-ui5-element",
"prepublishOnly": "npm run build"
},
"exports": {
"./.port": "./.port",
"./src/*": "./src/*",
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./bundle.esm.js": "./bundle.esm.js",
"./bundle.es5.js": "./bundle.es5.js",
"./bundle.common.js": "./bundle.common.js",
"./*": "./dist/*"
},
"repository": {
"type": "git",
"url": "https://github.com/SAP/ui5-webcomponents.git",
Expand Down
5 changes: 5 additions & 0 deletions packages/theme-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
"sapui5",
"ui5"
],
"exports": {
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./*": "./dist/*"
},
"scripts": {
"clean": "nps clean",
"build": "nps build",
Expand Down
13 changes: 13 additions & 0 deletions packages/tools/lib/init-package/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,19 @@ const updatePackageFile = () => {
"prepublishOnly": "npm run build"
};

// make convinient exports (no dist in component path)
// export the rest that is used directly or via require.resolve in scripts
packageContent.exports = {
"./.port": "./.port",
"./src/*": "./src/*",
"./dist/*": "./dist/*",
"./package.json": "./package.json",
"./bundle.esm.js": "./bundle.esm.js",
"./bundle.es5.js": "./bundle.es5.js",
"./bundle.common.js": "./bundle.common.js",
"./*": "./dist/*"
}

packageContent.ui5 = {
webComponentsPackage: true
};
Expand Down