Skip to content

fix(ui5-messagestrip): rename properties #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2021
Merged

fix(ui5-messagestrip): rename properties #3346

merged 2 commits into from
May 28, 2021

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented May 28, 2021 •
edited
Loading

Part of #3107

BREAKING_CHANGE: rename noIcon property to hideIcon
BREAKING_CHANGE: rename noCloseButton property to hideCloseButton

@ilhan007
Copy link
Member

Some merge conflicts otherwise +1

@fifoosid fifoosid mentioned this pull request May 28, 2021
Closed
@ilhan007
Copy link
Member

good to go

@ilhan007 ilhan007 merged commit 1cb43f2 into master May 28, 2021
@ilhan007 ilhan007 deleted the messagestrip-no branch May 28, 2021 13:53
kskondov pushed a commit that referenced this pull request May 31, 2021
@fifoosid @kskondov
fix(ui5-messagestrip): rename properties (#3346)
4527eab 
Part of #3107

BREAKING_CHANGE: The property `noIcon`  has been renamed to `hideIcon`
BREAKING_CHANGE: The property `noCloseButton` has been renamed to `hideCloseButton`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifoosid @ilhan007