Skip to content

fix: build error on MacOS 11 from rollup-plugin-terser #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

fix: build error on MacOS 11 from rollup-plugin-terser #3347

merged 1 commit into from
May 28, 2021

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented May 28, 2021

revert of revert of #2515 :D

@MapTo0
Copy link
Member Author

MapTo0 commented May 28, 2021

Looks like this is still the case for some Macs

@MapTo0 MapTo0 requested review from pskelin and tsanislavgatev May 28, 2021 12:39
tsanislavgatev
tsanislavgatev approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried it and it works for me.

@ilhan007 ilhan007 merged commit 59892c4 into master May 28, 2021
@ilhan007 ilhan007 deleted the fix-build-macos branch May 28, 2021 14:06
kskondov pushed a commit that referenced this pull request May 31, 2021
@MapTo0 @kskondov
fix: build error on MacOS 11 from rollup-plugin-terser (#3347)
f3bd42d 
revert of revert of #2515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MapTo0 @pskelin @tsanislavgatev @ilhan007