fix(inputs): use base CSS param for border-radius #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a standard css variable `--sapField_BorderCornerRadius` meant to be used for Input's border radius. It is 0.125rem in sap_fiori_3 and sap_fiori_3_dark and 0 in all other themes. This allows changing the border radius of all inputs via the Theme Designer
ilhan007
approved these changes
Jun 15, 2021
kskondov
pushed a commit
that referenced
this pull request
Jul 5, 2021
There is a standard css variable --sapField_BorderCornerRadius meant to be used for Input's border radius. It is 0.125rem in sap_fiori_3 and sap_fiori_3_dark and 0 in all other themes. This allows changing the border radius of all inputs via the Theme Designer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a standard css variable
--sapField_BorderCornerRadiusmeant to be used for Input's border radius. It is 0.125rem in sap_fiori_3 and sap_fiori_3_dark and 0 in all other themes. This allows changing the border radius of all inputs via the Theme Designer