Skip to content

feat(ui5-breadcrumbs): Initial implementation #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Aug 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
d229706
feat(ui5-breadcrumbs): Initial implementation
kineticjs Jul 2, 2021
6e1306c
fix(ui5-checkbox): add aria-hidden attribute to icon (#3511)
dobrinyonkov Jul 19, 2021
e6a3fbc
fix(ui5-checkbox): add aria-hidden attribute to icon (#3511)
dobrinyonkov Jul 19, 2021
39bbdb9
Merge branch 'breadcrumbs3' of https://github.com/kineticjs/ui5-webco…
kineticjs Jul 20, 2021
692c07b
Merge remote-tracking branch 'origin/master' into breadcrumbs3
kineticjs Jul 26, 2021
f66417d
rename the ui-link role to accessibleRole
kineticjs Jul 26, 2021
f7e57df
complemented separatorStyle documentation
kineticjs Jul 26, 2021
fac9c0a
added missing since tags
kineticjs Jul 26, 2021
9519beb
remove obsolete import
kineticjs Jul 26, 2021
331dc0c
correct jsdoc
kineticjs Jul 26, 2021
9410f1d
Update packages/main/src/Breadcrumbs.js
kineticjs Jul 26, 2021
e1e74c7
Update packages/main/src/BreadcrumbsItem.js
kineticjs Jul 26, 2021
dd264fb
Update packages/main/src/BreadcrumbsItem.js
kineticjs Jul 26, 2021
b34fdd8
correct jsdoc
kineticjs Jul 26, 2021
16bd55c
refactored event name to item-click
kineticjs Jul 26, 2021
4f0391d
corrected eslint errors
kineticjs Jul 26, 2021
f05210a
Update packages/main/src/types/BreadcrumbsSeparatorStyle.js
kineticjs Jul 26, 2021
23ba8d2
Update packages/main/src/Breadcrumbs.js
kineticjs Jul 26, 2021
e4054e9
Update packages/main/src/Breadcrumbs.js
kineticjs Jul 26, 2021
947e5a7
feat(ui5-breadcrumbs): Initial implementation
kineticjs Jul 2, 2021
47b3567
fix(ui5-checkbox): add aria-hidden attribute to icon (#3511)
dobrinyonkov Jul 19, 2021
39d9dc4
rename the ui-link role to accessibleRole
kineticjs Jul 26, 2021
f400a3d
complemented separatorStyle documentation
kineticjs Jul 26, 2021
19ec85d
added missing since tags
kineticjs Jul 26, 2021
cb343fa
remove obsolete import
kineticjs Jul 26, 2021
def1f02
correct jsdoc
kineticjs Jul 26, 2021
2f8dac6
Update packages/main/src/Breadcrumbs.js
kineticjs Jul 26, 2021
9e3fc81
Update packages/main/src/BreadcrumbsItem.js
kineticjs Jul 26, 2021
65b59db
Update packages/main/src/BreadcrumbsItem.js
kineticjs Jul 26, 2021
8c5d284
correct jsdoc
kineticjs Jul 26, 2021
332927a
refactored event name to item-click
kineticjs Jul 26, 2021
8125f1c
corrected eslint errors
kineticjs Jul 26, 2021
b70a61c
fixes
kineticjs Jul 27, 2021
4058a4e
Merge remote-tracking branch 'origin/breadcrumbs3' into breadcrumbs3
kineticjs Jul 27, 2021
a157155
interface definition
kineticjs Jul 27, 2021
3f75425
correct eslint error
kineticjs Jul 27, 2021
4256ea2
correct jsdoc
kineticjs Jul 27, 2021
31d8f80
some refactoring
kineticjs Jul 27, 2021
89242ee
no link target by default
kineticjs Jul 27, 2021
ccd3437
fix eslint error
kineticjs Jul 27, 2021
0978c62
remove comment
kineticjs Jul 27, 2021
f3fd49e
set focus on a label wrapper
kineticjs Jul 28, 2021
18eacef
fix eslint errors
kineticjs Jul 28, 2021
223e742
Merge remote-tracking branch 'origin/master' into breadcrumbs3
kineticjs Jul 28, 2021
311457e
adopt showAt function for popover
kineticjs Jul 29, 2021
9025715
corrected update of size cache for empty links
kineticjs Aug 1, 2021
cd6a11f
improve playground sample
kineticjs Aug 1, 2021
18ca3b5
Merge remote-tracking branch 'origin/master' into breadcrumbs3
kineticjs Aug 2, 2021
6e32852
enhance sample page to demonstrate the separator types
kineticjs Aug 2, 2021
2c663c6
improve keyboard handling docu and code
kineticjs Aug 2, 2021
abff553
improve keyboard handling docu
kineticjs Aug 2, 2021
fd1f218
rename overflowLink to dropdownArrowLink
kineticjs Aug 2, 2021
42fd0a5
remove redundant parenthesis
kineticjs Aug 2, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/main/bundle.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import "./dist/features/ColorPaletteMoreColors.js";
import Avatar from "./dist/Avatar.js";
import AvatarGroup from "./dist/AvatarGroup.js";
import Badge from "./dist/Badge.js";
import Breadcrumbs from "./dist/Breadcrumbs.js";
import BusyIndicator from "./dist/BusyIndicator.js";
import Button from "./dist/Button.js";
import Card from "./dist/Card.js";
Expand Down
42 changes: 42 additions & 0 deletions packages/main/src/Breadcrumbs.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<nav class="ui5-breadcrumbs-root"
aria-label="{{_accessibleNameText}}">
<ol @focusin="{{_onfocusin}}"
@keydown="{{_onkeydown}}"
@keyup="{{_onkeyup}}">

<li class="ui5-breadcrumbs-dropdown-arrow-link-wrapper"
?hidden="{{_isOverflowEmpty}}">
<ui5-link @click="{{_openRespPopover}}"
accessible-role="button"
aria-label="{{_dropdownArrowAccessibleNameText}}"
aria-haspopup="{{_ariaHasPopup}}">
<ui5-icon name="slim-arrow-down"
title="{{_dropdownArrowAccessibleNameText}}"></ui5-icon>
</ui5-link>
</li>

{{#each _linksData}}
<li class="ui5-breadcrumbs-link-wrapper" @click="{{../_onLinkPress}}">
<ui5-link
href="{{this.href}}"
target="{{this.target}}"
id="{{this._id}}-link"
aria-label="{{this.accessibleName}}"
data-ui5-stable="{{this.stableDomRef}}">
{{this.innerText}}
</ui5-link>
</li>
{{/each}}

{{#if _endsWithCurrentLocationLabel}}
<li class="ui5-breadcrumbs-current-location" @click="{{../_onLabelPress}}">
<span id={{this._id}}-labelWrapper>
<ui5-label
aria-current="page">
{{_currentLocationText}}
</ui5-label>
</span>
</li>
{{/if}}
</ol>
</nav>
Loading