refactor(ui5-select): change default slot from list items to options #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defines a new component ui5-option - removes Suggestions module BREAKING CHANGE: ui5-li is not anymore supported as a slot for ui5-select. Use ui5-option instead.
ilhan007
reviewed
Jun 10, 2019
| @@ -90,7 +90,7 @@ <h2> Change event counter holder</h2> | |||
| } | |||
|
|
|||
| suggestionItems.forEach(function(item) { | |||
| var li = document.createElement("ui5-li"); | |||
| var li = document.createElement("ui5-option"); | |||
There was a problem hiding this comment.
Actually this should stay as ui5-li, as this is ui5-input with suggestions
|
Check the build please? So we can review |
vladitasev
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: ui5-li is not anymore supported as a slot for ui5-select. Use ui5-option instead.