Skip to content

refactor(ui5-button): remove aria-disabled #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

elenastoyanovaa
Copy link
Contributor

As the button has a disabled attribute the aria-disabled attribute is not needed.

@elenastoyanovaa elenastoyanovaa requested a review from ilhan007 June 19, 2019 08:02
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@elenastoyanovaa elenastoyanovaa merged commit d61339d into master Jun 19, 2019
@elenastoyanovaa elenastoyanovaa deleted the button-remove-aria-disabled branch June 19, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants