Skip to content

feat(ui5-icon): use SVG icons instead of icon font #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Jul 19, 2019
Merged

feat(ui5-icon): use SVG icons instead of icon font #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
b017a8f
wip
pskelin Jul 2, 2019
67538ea
switch CalendarHeader to svg icon
pskelin Jul 5, 2019
8acf28e
switch Card to svg icon
pskelin Jul 5, 2019
b5495e7
switch datepicker and slotted icon in input to svg
pskelin Jul 5, 2019
d95d886
adopt messagestrip to svg icon usage
pskelin Jul 8, 2019
953d655
adopt svg icon in multicombobox
pskelin Jul 8, 2019
1b95b8a
adapt panel to svg icon
pskelin Jul 8, 2019
0fa95ff
adapt select to svg icon
pskelin Jul 8, 2019
8006ff1
add improved icons
pskelin Jul 15, 2019
33e7cf3
adapt DatePicker and CalendarHeader
ilhan007 Jul 16, 2019
6d3ed58
adopt Panel icon size
ilhan007 Jul 16, 2019
2cd2a04
adopt compact size of slotted icon in Input
ilhan007 Jul 16, 2019
ac683c3
adopt svg icon in Select
ilhan007 Jul 16, 2019
84b7a43
convert path data to static 512x512
pskelin Jul 16, 2019
959a44f
shellbar adopted
MapTo0 Jul 16, 2019
c5fc692
adapt Panel to use svg icon
ilhan007 Jul 16, 2019
2a25817
fix Select opens on icon click
ilhan007 Jul 16, 2019
7d23208
adopt MessageStrip to use svg icon
ilhan007 Jul 16, 2019
41480fe
adapt ListItem to use svg icons
ilhan007 Jul 17, 2019
3529b7e
adapt TimelineItem to use svg icons
ilhan007 Jul 17, 2019
458e342
adopt multi combo box
MapTo0 Jul 17, 2019
ede24ec
adopt token - no changes needed
MapTo0 Jul 17, 2019
11a9b8b
fix tests
MapTo0 Jul 17, 2019
fa5cbfc
add necessary icon imports
MapTo0 Jul 17, 2019
0d0a056
adopt TabContainer to use svg icons
ilhan007 Jul 17, 2019
8058453
fix eslint : (
ilhan007 Jul 17, 2019
d98a5c3
replace icon with svgicon
MapTo0 Jul 17, 2019
ac25b52
adopt tests
MapTo0 Jul 17, 2019
865be8d
remove icon qunit
MapTo0 Jul 17, 2019
7eca2b6
fix Input slotted icon centering
ilhan007 Jul 18, 2019
67cf881
merge measter into branch
ilhan007 Jul 18, 2019
f14d3d4
remove obsolete files and commented code
ilhan007 Jul 18, 2019
c6765f0
Fix Ilhan's eslint errors
MapTo0 Jul 18, 2019
e4051e7
log an error and a suggestion which item should be imported
MapTo0 Jul 18, 2019
ea9a5cd
adopt checkbox to use svg icon instead of icon font
MapTo0 Jul 18, 2019
0001cb5
correct checkbox state colors
MapTo0 Jul 18, 2019
2e3408b
fix CheckBox mark in compact
ilhan007 Jul 18, 2019
410a8c9
adopt svg icons in Switch
ilhan007 Jul 18, 2019
34ab9dd
fix DatePicker bind for one click only
ilhan007 Jul 18, 2019
4947c8f
fix build
ilhan007 Jul 18, 2019
ab3afa8
fixes for IE
ilhan007 Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions docs/HowToUse.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ properties and attributes.
An example of such web component is the `ui5-icon`:

```html
<ui5-icon src="sap-icons://add"></ui5-icon>
<ui5-icon src="sap-icon://add"></ui5-icon>
```

The icon accepts no text or other HTML elements inside its opening and closing tags.
Therefore, in the next example, the text inside the `<ui5-icon>` will be ignored.

```html
<ui5-icon src="sap-icons://add">This is an icon</ui5-icon>
<ui5-icon src="sap-icon://add">This is an icon</ui5-icon>
```

Other UI5 Web Components, such as `<ui5-button>` accept text (and in addition HTML elements that make sense when writing text)
Expand Down
Loading