Skip to content

fix(ui5-slider): enhance storybook samples #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix(ui5-slider): enhance storybook samples #7460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e2f1d
fix(ui5-slider): enhance storybook samples
niyap Aug 18, 2023
7f58c9a
fix(ui5-slider): apply review comments
niyap Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 41 additions & 25 deletions packages/playground/_stories/main/RangeSlider/RangeSlider.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { ifDefined } from "lit/directives/if-defined.js";
const component = "ui5-range-slider";

export default {
title: "Main/RangeSlider",
title: "Main/Range Slider",
component: "RangeSlider",
parameters: {
docs: {
Expand All @@ -35,38 +35,54 @@ const Template: UI5StoryArgs<RangeSlider, StoryArgsSlots> = (args) => html`
?show-tooltip="${ifDefined(args.showTooltip)}"
></ui5-range-slider>`;

export const BasicRangeSlider = Template.bind({});
BasicRangeSlider.args = {
export const Basic = Template.bind({});
Basic.decorators = [
(story) => {
return html`
<div class="wrapper" style="margin-top:1rem;">
${story()}
</div>
`;
}
]
Basic.args = {
min: 0,
max: 100,
step: 5,
disabled: false,
showTooltip: false,
showTickmarks: false,
labelInterval: 0,
startValue: 0,
endValue: 20
};

export const RangeSliderCustomValues = Template.bind({});
RangeSliderCustomValues.args = {
min: 100,
max: 200,
startValue: 120,
endValue: 150
};
RangeSliderCustomValues.storyName = "Range Slider with Custom 'min', 'max', 'startValue' and 'endValue' Properties";

export const RangeSliderTooltip = Template.bind({});
RangeSliderTooltip.args = {
export const WithTooltips = Template.bind({});
WithTooltips.decorators = [
(story) => {
return html`
<div class="wrapper" style="margin-top:1rem;">
${story()}
</div>
`;
}
]
WithTooltips.args = {
startValue: 3,
endValue: 13,
showTooltip: true
};
RangeSliderTooltip.storyName = "Range Slider with Tooltips";

export const RangeSliderTickmarksCustomStep = Template.bind({});
RangeSliderTickmarksCustomStep.args = {
step: 2,
startValue: 12,
endValue: 24,
showTickmarks: true
};
RangeSliderTickmarksCustomStep.storyName = "Range Slider with Tickmarks and Custom Step";

export const RangeSliderTickmarksTooltipLabel = Template.bind({});
RangeSliderTickmarksTooltipLabel.decorators = [
(story) => {
return html`
<div class="wrapper" style="margin-top:1rem;">
${story()}
</div>
`;
}
]
RangeSliderTickmarksTooltipLabel.args = {
min: 0,
max: 112,
Expand All @@ -77,4 +93,4 @@ RangeSliderTickmarksTooltipLabel.args = {
showTickmarks: true,
showTooltip: true
};
RangeSliderTickmarksTooltipLabel.storyName = "Range Slider with Tooltips, Tickmarks and Labels";
RangeSliderTickmarksTooltipLabel.storyName = "With Tooltips, Tickmarks and Labels";
57 changes: 40 additions & 17 deletions packages/playground/_stories/main/Slider/Slider.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,30 +36,53 @@ const Template: UI5StoryArgs<Slider, StoryArgsSlots> = (args) => html`
accessible-name="${ifDefined(args.accessibleName)}"
></ui5-slider>`;

export const BasicSlider = Template.bind({});
export const Basic = Template.bind({});
Basic.decorators = [
(story) => {
return html`
<div class="wrapper" style="margin-top:1rem;">
${story()}
</div>
`;
}
]
Basic.args = {
min: 0,
max: 100,
step: 5,
disabled: false,
showTooltip: false,
showTickmarks: false,
labelInterval: 0
};

export const SliderTooltip = Template.bind({});
SliderTooltip.args = {
export const WithTooltip = Template.bind({});
WithTooltip.decorators = [
(story) => {
return html`
<div class="wrapper" style="margin-top:1rem;">
${story()}
</div>
`;
}
]
WithTooltip.args = {
min: 0,
max: 20,
showTooltip: true,
labelInterval: 5

};
SliderTooltip.storyName = "Slider with Tooltip";

export const DisabledTickmarksLabel = Template.bind({});
DisabledTickmarksLabel.args = {
min: 20,
max: 100,
labelInterval: 5,
disabled: true,
showTickmarks: true
};
DisabledTickmarksLabel.storyName = "Disabled Slider with Tickmarks and Labels";


export const TickmarksLabelTooltip = Template.bind({});
TickmarksLabelTooltip.decorators = [
(story) => {
return html`
<div class="wrapper" style="margin-top:1rem;">
${story()}
</div>
`;
}
]
TickmarksLabelTooltip.args = {
min: -20,
max: 20,
Expand All @@ -69,4 +92,4 @@ TickmarksLabelTooltip.args = {
labelInterval: 2,
showTickmarks: true
};
TickmarksLabelTooltip.storyName = "Slider Tooltip, Tickmarks and Labels";
TickmarksLabelTooltip.storyName = "With Tooltip, Tickmarks and Labels";