feat: implement create control script #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vladitasev
requested review from
ilhan007,
vladitasev,
pskelin,
fifoosid and
MapTo0
fifoosid
approved these changes
Aug 26, 2019
|
@tsanislavgatev you have to sign the cla in order to push the PR |
|
vladitasev
requested changes
Aug 26, 2019
| const sComponentName = aArgs[0]; | ||
| const oPaths = { | ||
| "js": `./src/${sComponentName}.js`, | ||
| "css": `./src/themes/${sComponentName}.css`, |
There was a problem hiding this comment.
We might need some more css files (for all the themes as well) Please ask Philip whether it's a good idea to add the other files as well (based on his experience with component development)
There was a problem hiding this comment.
We decided that this is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a script for automatically create files by template for new web component.