Skip to content

header inclusion issues for STM32U545xx #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rob-zeno opened this issue Feb 28, 2024 · 4 comments
Closed

header inclusion issues for STM32U545xx #41

rob-zeno opened this issue Feb 28, 2024 · 4 comments
Assignees
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request.
Milestone

Comments

@rob-zeno
Copy link

I'm trying to get Zephyr RTOS working on Nucleo U545RE-Q board, with an STM32U545RET6Q part on it.

Zephyr RTOS uses the STM32U5xx_HAL_Driver for certain functionality. According to engineers there, it copies the stm32_hal_conf_template.h file to stm32_hal_conf.h, leaving all of the options defined.

Unfortunately, the HAL_SRAM_MODULE_ENABLED, HAL_NAND_MODULE_ENABLED and HAL_NOR_MODULE_ENABLED definitions include files that do not compile for the STM32U545 family.

According to one of the engineers on the Zephyr team, the problematic included files (stm32u5xx_hal_sram.h, stm32u5xx_hal_nor.h and stm32u5xx_hal_nand.h) need to have:

 #if defined(FMC_BANK1)
 ...
 #endif

around the contents. As an example, he points to the STM32CubeG4 where this approach is used.

I can prepare a PR with these changes, but thought I would bring the issue up here first.

@ALABSTM ALABSTM added bug Something isn't working hal HAL-LL driver-related issue or pull-request. labels Mar 1, 2024
@ALABSTM
Copy link
Contributor

ALABSTM commented Mar 1, 2024

See also stm32u5xx_hal_driver#6

@ALABSTM
Copy link
Contributor

ALABSTM commented Mar 1, 2024

Hi @rob-zeno,

Thank you for this report. It looks like there is a typo in the title. I suppose you mean "U545" instead of "H545". Would you mind correcting it please to avoid any confusion?

Thank you,

@TOUNSTM TOUNSTM added this to the v1.5.0 milestone Mar 1, 2024
@TOUNSTM
Copy link
Contributor

TOUNSTM commented Mar 1, 2024

Hello @rob-the-dude,

Thank you for your contribution. You are absolutely right about this point.
Actually, the point you raised has already been dealt and fixed internally. The fix will be made available in the frame of a future release.
please allow me to close this issue and ensure that our conversation remains focused on this pull-request STMicroelectronics/stm32u5xx-hal-driver#7

Thank you again for your contribution. We are looking forward to reading from you again.

With regards,

@TOUNSTM TOUNSTM closed this as completed Mar 1, 2024
@rob-zeno rob-zeno changed the title header inclusion issues for STM32H545xx header inclusion issues for STM32U545xx Mar 2, 2024
@rob-zeno
Copy link
Author

rob-zeno commented Mar 2, 2024

Thank you for this report. It looks like there is a typo in the title. I suppose you mean "U545" instead of "H545". Would you mind correcting it please to avoid any confusion?

Whoops, you're right! Been working with too many different chip families!

Thanks for everyone's help here!

@ALABSTM ALABSTM changed the title header inclusion issues for STM32U545xx header inclusion issues for STM32H545xx Mar 4, 2024
@ALABSTM ALABSTM changed the title header inclusion issues for STM32H545xx header inclusion issues for STM32U545xx Mar 4, 2024
rob-zeno added a commit to rob-zeno/hal_stm32 that referenced this issue Mar 18, 2024
…pport

building for the STM32U545 chip.  These changes have been provided to
ST (STMicroelectronics/STM32CubeU5#41).  However,
they have fixed the issue internally and are awaiting a future release to
push them out.

I am in the process of creating a PR for Zephyr-proper to add support for
the STM32U545 part as well as the Nucleo-U545RE-Q board.  That PR is
dependent on these changes.

Signed-off-by: Rob Newberry <[email protected]>
erwango pushed a commit to zephyrproject-rtos/hal_stm32 that referenced this issue Mar 20, 2024
…pport

building for the STM32U545 chip.  These changes have been provided to
ST (STMicroelectronics/STM32CubeU5#41).  However,
they have fixed the issue internally and are awaiting a future release to
push them out.

I am in the process of creating a PR for Zephyr-proper to add support for
the STM32U545 part as well as the Nucleo-U545RE-Q board.  That PR is
dependent on these changes.

Signed-off-by: Rob Newberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request.
Projects
Development

No branches or pull requests

3 participants