Test the interface before just assuming its gtg. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for us to fallback for private-mode iOS/Android.
|
👍 - This issue is the worst. Been bitten by this on Safari at least once. I really dislike how they advertise the interface but then throw when you use it. Chrome does the right thing IMO, which is to make the interface work but simply clear the data when closing the tab. Happy to accept this, but is there a reason why you've changed the tabbing (2 spaces to 4)? |
|
sorry about that. all my projects use tabs, and I just wasn't thinking when I opened the file in my editor. |
STRML
added a commit
that referenced
this pull request
Mar 15, 2015
Test the interface before just assuming its gtg.
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for us to fallback for private-mode iOS/Android.