Skip to content

Fallback to default browser behavior for "special" clicks. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeffreywescott
Copy link

If the user did a middle-click, right-click, or used a modifier key (like ctrl-click, meta-click, shift-click, etc.), fallback to default browser behavior.

…like ctrl-click, meta-click, shift-click, etc.), fallback to default browser behavior
@brendanmoore
Copy link
Contributor

+1

2 similar comments
@bpneal
Copy link

bpneal commented Jul 10, 2014

+1

@jcurtis
Copy link

jcurtis commented Jul 16, 2014

👍

@STRML
Copy link
Owner

STRML commented Sep 18, 2014

This was addressed in 9984d76 - do you see any reason to specifically exclude right-clicks, shift-clicks, or alt-clicks?

@jeffreywescott
Copy link
Author

Yes -- modified clicks have different semantics that we don't want to override. For example, "Save Image As", etc.

@STRML
Copy link
Owner

STRML commented Sep 19, 2014

Shift-click in particular, or right click? Right clicks don’t appear to be caught at all in any case, but that’s just in my testing.

On Sep 19, 2014, at 12:03 PM, Jeffrey Wescott [email protected] wrote:

Yes -- modified clicks have different semantics that we don't want to override. For example, "Save Image As", etc.


Reply to this email directly or view it on GitHub.

@jeffreywescott
Copy link
Author

My opinion is that we only want unmodofied clicks to be considered navigation. That's what is true for all links in the browser. Why should this be different?

@STRML STRML closed this in 506b1a2 Sep 19, 2014
@STRML
Copy link
Owner

STRML commented Sep 19, 2014

Ok, I've taken the more complete version from this PR and adapted it into <Link>. It is released as 0.21.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants