Skip to content

Provide GitHub action #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

Shinigami92
Copy link
Contributor

closes #239

@Shinigami92
Copy link
Contributor Author

See https://github.com/Shinigami92/ore-seeker/pull/9/files for a test
works absolutely perfectly 🤩

Comment on lines +17 to +20
run: |
if [ ! -f requirements.txt ]; then
echo "gdtoolkit==${{inputs.version}}" > requirements.txt
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only needed, because otherwise the actions/setup-python@v4 with cache: "pip" would fail
It searches for a requirements.txt or pyproject.toml
If this does not exists, the install-python would fail 🤷

Because Godot projects are usually not a python project, we need to fake that file

@Scony
Copy link
Owner

Scony commented Oct 24, 2023

Thanks! Please give me a couple days to review.

@Scony Scony merged commit 423120c into Scony:master Nov 1, 2023
@Scony
Copy link
Owner

Scony commented Nov 1, 2023

Looks good, thanks! Can you update your project to use this one now that it's merged? I'll give it a try in one of my projects as well.

@Shinigami92 Shinigami92 deleted the provide-github-action branch November 1, 2023 18:33
@Shinigami92
Copy link
Contributor Author

It's working, not taken from a marketplace but straight from the repo 🤷
But anyways
Feels much more official now ^^

@Scony
Copy link
Owner

Scony commented Nov 1, 2023

@Shinigami92 I've added it to https://github.com/lampe-games/godot-open-rts and it works like a charm! Really nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a GitHub Action
3 participants