Issue-1398: set umask when launching browsers #1399
Conversation
This comment has been minimized.
This comment has been minimized.
This is one of the symptoms I saw which caused me to look for a solution. I'm not actually very happy with the solution I've come up with as it is too high level, I would prefer 002 to be the default for all user processes, or at least for seluser's. I did try to modify /etc/profile and seluser's profile, but I couldn't get it to work. Maybe the real solution is to make the change to supervisord.conf, but I don't have much experience with supervisord (I was a sys admin when Solaris was king!) |
I believe it firefox will also have this problem, but we don't use Firefox in our environment |
# Conflicts: # NodeChrome/wrap_chrome_binary # NodeEdge/wrap_edge_binary
|
|
|
@diemol, I believe I have addressed the changes you requested. |
|
Apologies for the delay reviewing this PR, we've been busy with the 4.0 release. We will review this in the next couple of days. Thanks! |
|
No problem and congratulations! I've been running 4 fairly successfully for
a few weeks now.
…On Thu, Oct 14, 2021 at 8:16 AM Diego Molina ***@***.***> wrote:
Apologies for the delay reviewing this PR, we've been busy with the 4.0
release. We will review this in the next couple of days. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1399 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZHWXMJX3AO4NFM23OVCLUG3C3NANCNFSM5EFVVUBA>
.
|
|
@therealdjryan I was going to start reviewing this but seems something went wrong with the latest commits. Why are there so many changes in the this PR? |
|
@diemol wow that's ugly! Pretty sure all I did was to sync the fork in IntelliJ. I'll ditch this fork and create a clean one. |
|
@diemol, I updated my fork using the github UI and my commits look normal again. |
There was a problem hiding this comment.
This does not fix #1095 because it is a different issue.
Thanks for contributing, @therealdjryan!
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Set umask to 002 before launching browsers. This will cause downloaded files to 664 (-rw-rw-r)
#1398
Description
Motivation and Context
Allows changing downloaded files when run in an environment where the userids don't map
Types of changes
Checklist